fix API key persistence #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thought about doing in the first place (and shouldve\!)
This was referenced Mar 5, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This swaps the evaluation order of the blocks for the svelte stores (and session/local storage) of 'api-key' and 'store-api-key'. Also updates some comments a little.
Each of the stores'
.subscribe()event handlers are called immediately after registration (w/ the initial value as an argument). Because of that, prior to this PR, the "store api key flag" was processed before the "api key" was retrieved from persistent storage, thereby overwriting a previously saved api key with an empty value. Now, a pre-existing api key is loaded before any attempt to save it back to persistent storage.