Skip to content

fix API key persistence #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 5, 2025
Merged

fix API key persistence #98

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
63c08f9
make sure sessionStorage initially gets populated with api-key from l…
melange396 Mar 5, 2025
6308ea7
typescript store syntax is fun
melange396 Mar 5, 2025
e98f9fa
typescript store syntax is fun, take 2
melange396 Mar 5, 2025
aba106e
typescript store syntax is fun, take 3
melange396 Mar 5, 2025
2af47cc
typescript store syntax is fun, take 4
melange396 Mar 5, 2025
2881891
typescript store syntax is fun, take 5
melange396 Mar 5, 2025
3ed0220
more precise comments
melange396 Mar 5, 2025
eb06244
debug logging
melange396 Mar 5, 2025
f6e2bea
the linter is a PITA
melange396 Mar 5, 2025
c1a1215
the linter is a PITA, esp cuz it doesnt tell you what the problem is
melange396 Mar 5, 2025
61c442b
the linter is a PITA, REEEEEEEEEEEE
melange396 Mar 5, 2025
c0ed939
better debug logging
melange396 Mar 5, 2025
9a2a92e
swapped eval order for 'api-key' and 'store-api-key' blocks, which i …
melange396 Mar 5, 2025
0caeadb
removed logging
melange396 Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,16 @@ formSelections.subscribe((val) => {
sessionStorage.setItem('form', JSON.stringify(val));
});

export const apiKey = writable(localStorage.getItem('api-key')! || '');
apiKey.subscribe((val) => {
// always keep key in session storage (resets on window close)
sessionStorage.setItem('api-key', val);
if (localStorage.getItem('store-api-key') === 'true') {
// if flag set, also store key in local persistent storage
localStorage.setItem('api-key', val);
}
});

export const storeApiKeys = writable(localStorage.getItem('store-api-key') === 'true');
storeApiKeys.subscribe((val) => {
localStorage.setItem('store-api-key', val.toString());
Expand All @@ -47,16 +57,6 @@ storeApiKeys.subscribe((val) => {
}
});

export const apiKey = writable(localStorage.getItem('api-key')! || '');
apiKey.subscribe((val) => {
// always keep key around in session storage (resets on page refresh)
sessionStorage.setItem('api-key', val);
if (localStorage.getItem('store-api-key') === 'true') {
// store it in local storage (persistent)
localStorage.setItem('api-key', val);
}
});

export function addDataSet(dataset: DataSet | DataGroup): void {
const root = get(datasetTree);
root.datasets.push(dataset);
Expand Down