feat: send `multisig` with certificate #926

goran-ethernal · 2025-09-01T11:40:28Z

🔄 Changes Summary

This PR updates the agglayer SubmitCertificate API which now supports sending multisig with the certificate.

multisig is sent in the AggchainData field in the Certificate which supports four types:

AggchainDataProof - in the case of FEP network with multisig turned off.
AggchainDataSignature - in the case of PP network with multisig turned off.
AggchainDataMultisigWithProof - in the case of FEP network with multisig turned on.
AggchainDataMultisig - in the case of PP network with multisig turned on.

⚠️ Breaking Changes

NA

📋 Config Updates

NA

✅ Testing

🤖 Automatic: aggkit CI

aggsender/aggsender.go

aggsender/flows/flow_pp.go

agglayer/types/types.go

aggsender/aggsender.go

Copilot

Pull Request Overview

This PR implements multisig support for the certificate submission API in the AggLayer. The main purpose is to update the AggLayer SubmitCertificate API to support sending multisig data alongside certificates, enabling support for both FEP and PP networks with multisig capabilities.

Added new AggchainData types (AggchainDataMultisig and AggchainDataMultisigWithProof) to support multisig certificates
Updated the certificate validation flow to handle multisig collection and include it in the certificate data
Modified API signatures to remove separate validator signature parameter since multisig data is now embedded in the certificate

Reviewed Changes

Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
go.mod	Updates AggLayer protobuf dependencies to support new multisig API
aggsender/validator/	Adds Index() method to validators and updates constructor to accept signer index
aggsender/types/	Adds UpdateAggchainData method to flow interface for multisig handling
aggsender/flows/	Implements UpdateAggchainData for both PP and AggchainProver flows
aggsender/aggsender.go	Updates certificate sending flow to collect multisig and embed in certificate
agglayer/types/	Adds new multisig data types and updates NetworkStatus to NetworkState
agglayer/grpc/	Updates client to handle new multisig certificate types and API changes

Comments suppressed due to low confidence (2)

aggsender/aggsender.go:1

The format string uses %w for error formatting in Warnf, but %w is only valid for fmt.Errorf to wrap errors. Use %v instead for logging the error.

package aggsender

aggsender/aggsender.go:1

The format verb should be %v instead of %w when logging errors. The %w verb is only for error wrapping in fmt.Errorf.

package aggsender

agglayer/types/types_test.go

Stefan-Ethernal

Generally LGTM, but leaving some comments to consider.

aggsender/aggsender.go

agglayer/types/types.go

aggsender/aggsender.go

aggsender/flows/flow_aggchain_prover.go

aggsender/validator/compare_certs.go

sonarqubecloud · 2025-09-04T08:04:34Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
91.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

## 🔄 Changes Summary Enable the AggSender to work with multiple validator nodes in a committee-based validation system. The implementation includes validator services, multisig committee management, certificate validation improvements, and enhanced gRPC communication protocols. **Multisig Committee Support:** - Added `MultisigCommittee` type to manage signer sets and enforce signature thresholds. - Signers are represented as `SignerInfo` structs with both address and URL for improved context and error reporting. - Committee construction validates non-empty membership and non-zero threshold, preventing misconfiguration. - Dynamic signer management: methods for adding signers, duplicate checks by address and URL. **Aggsender Validator Refactor:** - The Aggsender certificate validation flow was refactored to integrate multisig logic. - The multisig validation logic is applicable to both `PP` and `FEP` certificates. - Certificate validation now checks for contiguous certificates, last L2 block, and settlement status using new queries. - Import bridge exit proof verification is handled via new logic using `verifyClaimProofs`, ensuring only valid proofs pass. **Certificate Metadata removal:** - It is gone from the agglayer and therefore it is not sent anymore from the aggsender either. - Only thing worth noting is that, when calculating `CertificateID`, instead of metadata field, which was used previously, we now use `ZeroHash`. **Smart contracts integration:** - **AggchainFEP contract:** Removed querying of `TrustedSequencer` address and rely on the signers committee instead - **AggchainBase contract:** Retrieve the multisig committee from the `AggchainBase` contract **Agglayer integration:** - Invoke the `GetNetworkState` API from agglayer to get the latest settled imported bridge exit info. - Multisig is populated into the certificate and sent to the Agglayer's `SendCertificate` gRPC endpoint ## ⚠️ Breaking Changes - 🛠️ **Config**: Make sure that `Mode` on the `Validator` and `AggSender` are the same. - 🔌 **API/CLI**: `aggkit` version (`v0.7.0`) that supports `multisig` will now require updated contracts to run. At least version `v12.1.0-rc.3` of `agglayer-contracts`, and a new version of `agglayer` which supports `multisig`, which is the `v0.4.0` of `agglayer`. - 🗑️ **Deprecated Features**: Aggsender Phase II validator signing logic ## 📋 Config Updates - Added `AggSender.RequireCommitteeMembershipCheck = false` parameter, which defines if a check on `aggsender proposer` startup will be performed to see if the proposer is in the `multisig` committee. - Added `Validator.RequireCommitteeMembershipCheck = {{AggSender.RequireCommitteeMembershipCheck}}` parameter, which defines if a check on `aggsender validator` startup will be performed to see if the validator is in the `multisig` committee. - Added `Validator.Mode = "PessimisticProof"` parameter, which acts the same as the `AggSender.Mode`. It tells the validator that the network is a `PP` network or an `FEP` network. It has to be the same as on `aggsender proposer`. - Added `Validator.FEPConfig.SovereignRollupAddr = "{{AggSender.SovereignRollupAddr}}" parameter which is the address of the `AggchainFEP` rollup on L1 for given network for which validator is running. - Added `Validator.FEPConfig.RequireNoBlockGap = {{AggSender.RequireNoFEPBlockGap}}, which acts the same as the given paremeter on `AggSender` (proposer) config, and tells the validator if gaps in blocks in certificates are allowed in `FEP` network. ```toml [AggSender] RequireCommitteeMembershipCheck = false [Validator] # PessimisticProof or AggchainProof Mode = "PessimisticProof" RequireCommitteeMembershipCheck = {{AggSender.RequireCommitteeMembershipCheck}} [Validator.FEPConfig] SovereignRollupAddr = "{{AggSender.SovereignRollupAddr}}" RequireNoBlockGap = "{{AggSender.RequireNoFEPBlockGap}}" ``` ## ✅ Testing - 🤖 **Automatic**: `aggkit` CI - 🖱️ **Manual**: [Optional: Steps to verify] ## 🐞 Issues - Closes #792 ## 🔗 Related PRs - #814 - #832 - #838 - #839 - #843 - #842 - #846 - #858 - #847 - #865 - #861 - #863 - #875 - #876 - #881 - #877 - #898 - #920 - #913 - #926 - #945 - #951 - #954 - #957 - #955 - #974 - #978 - #985 - #989 - #984 - #998 - #1017 - #1028 - #1034 - #1024 - #1052 - #1067 - #1068 - #1050 - #1071 - #1072 - #1060 - #1087 - #1077 - #1073 --------- Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Joan Esteban <[email protected]> Co-authored-by: Rachit Sonthalia <[email protected]> Co-authored-by: Arpit Temani <[email protected]> Co-authored-by: Copilot <[email protected]>

goran-ethernal self-assigned this Sep 1, 2025

goran-ethernal added aggsender aggsender-proposer labels Sep 1, 2025

goran-ethernal force-pushed the feat/send_multisig_with_certificate branch 6 times, most recently from b9f3ee5 to 72f81c2 Compare September 2, 2025 07:40

joanestebanr reviewed Sep 2, 2025

View reviewed changes

aggsender/aggsender.go Show resolved Hide resolved

aggsender/flows/flow_pp.go Show resolved Hide resolved

aggsender/flows/flow_pp.go Show resolved Hide resolved

joanestebanr reviewed Sep 2, 2025

View reviewed changes

agglayer/types/types.go Outdated Show resolved Hide resolved

joanestebanr reviewed Sep 2, 2025

View reviewed changes

aggsender/aggsender.go Show resolved Hide resolved

aggsender/aggsender.go Show resolved Hide resolved

goran-ethernal added 5 commits September 2, 2025 11:04

feat: update proto definition

a9868e8

feat: remove old signature in send certificate

fbc4524

feat: utilize new API

8fac97e

feat: uts

3c595dc

feat: update to rc2 protobuf

3cb5fef

goran-ethernal force-pushed the feat/send_multisig_with_certificate branch from 72f81c2 to 3cb5fef Compare September 2, 2025 09:34

fix: comment

852bfd4

goran-ethernal marked this pull request as ready for review September 2, 2025 10:48

goran-ethernal requested review from Stefan-Ethernal and Copilot September 2, 2025 10:48

Copilot AI reviewed Sep 2, 2025

View reviewed changes

agglayer/types/types_test.go Show resolved Hide resolved

go mod tidy

9eaae07

Stefan-Ethernal approved these changes Sep 2, 2025

View reviewed changes

aggsender/aggsender.go Outdated Show resolved Hide resolved

aggsender/aggsender.go Show resolved Hide resolved

agglayer/types/types.go Outdated Show resolved Hide resolved

aggsender/aggsender.go Outdated Show resolved Hide resolved

aggsender/aggsender.go Outdated Show resolved Hide resolved

goran-ethernal added 3 commits September 2, 2025 15:21

fix: comments

8ba71cb

feat: add validation of imported bridge exits

50a8012

feat: conversion of new aggchain data

3543901

goran-ethernal force-pushed the feat/send_multisig_with_certificate branch from 6c4540c to 3543901 Compare September 3, 2025 09:15

goran-ethernal requested a review from joanestebanr September 3, 2025 12:57

fix: change custom marshal/unmarshal

2e6311b

joanestebanr reviewed Sep 3, 2025

View reviewed changes

aggsender/aggsender.go Show resolved Hide resolved

aggsender/aggsender.go Outdated Show resolved Hide resolved

aggsender/flows/flow_aggchain_prover.go Show resolved Hide resolved

joanestebanr reviewed Sep 3, 2025

View reviewed changes

aggsender/validator/compare_certs.go Show resolved Hide resolved

fix: comments

2db88f3

goran-ethernal requested a review from joanestebanr September 3, 2025 15:49

feat: add check for global index

fa4a139

joanestebanr approved these changes Sep 4, 2025

View reviewed changes

goran-ethernal merged commit c0dd242 into feat/aggsender-multisig Sep 4, 2025
21 of 22 checks passed

goran-ethernal deleted the feat/send_multisig_with_certificate branch September 4, 2025 09:00

Stefan-Ethernal mentioned this pull request Sep 9, 2025

feat: Aggsender multisig #860

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: send `multisig` with certificate #926

feat: send `multisig` with certificate #926

Uh oh!

goran-ethernal commented Sep 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Stefan-Ethernal left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: send multisig with certificate #926

feat: send multisig with certificate #926

Uh oh!

Conversation

goran-ethernal commented Sep 1, 2025

🔄 Changes Summary

⚠️ Breaking Changes

📋 Config Updates

✅ Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Stefan-Ethernal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 4, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: send `multisig` with certificate #926

feat: send `multisig` with certificate #926