fix: hardcode finalized block for bridge l1 syncer #1077

Stefan-Ethernal · 2025-10-02T13:26:30Z

🔄 Changes Summary

In case the block finality is set to Empty, which is case for the BridgeL1Sync component, due to config BridgeL1Sync.BlockFinality being deprecated, we are hardcoding the block finality to the FinalizedBlock.
Also in case, Empty block finality is received to the EVMDownloader, we are returning an error.
Remove the BlockFinality from BridgeSync, as it was not being used anywhere, except the unit tests.
Rename BlockNumberFinality.GreaterThan to BlockNumberFinality.LessFinalThan, and make it slightly more understandable.
Remove redundant check when declaring block as finalized in evm downloader. It is enough checking whether the given block is less or equal to the last finalized block (whatever we have configured as the finalized commitment).

⚠️ Breaking Changes

N/A

📋 Config Updates

N/A

✅ Testing

🤖 Automatic: Test_ResolveBlockFinality unit test
🖱️ Manual:

Spin up the aggkit with bridge service
Note that there is not the following log entry in the aggkit log for L1BridgeSyncer, since it is now initialized with the finalized keyword for block finality:

"finalized block type FinalizedBlock is greater than block finality , setting finalized block type to "

🐞 Issues

Closes handle empty block finality in evm downloader #1078

🔗 Related PRs

[Optional: Enumerate related pull requests]

📝 Notes

[Optional: design decisions, tradeoffs, or TODOs]

joanestebanr

What is the case that BlockFinality is Empty?

Stefan-Ethernal · 2025-10-03T06:43:59Z

What is the case that BlockFinality is Empty?

In the BridgeL1Sync config, the BlockFinality is omitted (it was supposed to be FinalizedBlock, but it isn't the case, since it is omitted and an empty string implicitly):

[BridgeL1Sync]
DBPath = "{{PathRWData}}/bridgel1sync.sqlite"
InitialBlockNum = 0
BridgeAddr = "{{polygonBridgeAddr}}"
SyncBlockChunkSize = 100
RetryAfterErrorPeriod = "1s"
MaxRetryAttemptsAfterError = -1
WaitForNewBlocksPeriod = "3s"
RequireStorageContentCompatibility = {{RequireStorageContentCompatibility}}
DBQueryTimeout = "{{defaultDBQueryTimeout}}"

We could provide here the aggkittypes.FinalizedBlock for sure, but with the fix I made we are sure that we are not going to set the Empty block finality.

sync/evmdownloader_test.go

rachit77

LGTM

sync/evmdownloader.go

sonarqubecloud · 2025-10-07T09:30:55Z

Quality Gate failed

Failed conditions
75.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

## 🔄 Changes Summary Enable the AggSender to work with multiple validator nodes in a committee-based validation system. The implementation includes validator services, multisig committee management, certificate validation improvements, and enhanced gRPC communication protocols. **Multisig Committee Support:** - Added `MultisigCommittee` type to manage signer sets and enforce signature thresholds. - Signers are represented as `SignerInfo` structs with both address and URL for improved context and error reporting. - Committee construction validates non-empty membership and non-zero threshold, preventing misconfiguration. - Dynamic signer management: methods for adding signers, duplicate checks by address and URL. **Aggsender Validator Refactor:** - The Aggsender certificate validation flow was refactored to integrate multisig logic. - The multisig validation logic is applicable to both `PP` and `FEP` certificates. - Certificate validation now checks for contiguous certificates, last L2 block, and settlement status using new queries. - Import bridge exit proof verification is handled via new logic using `verifyClaimProofs`, ensuring only valid proofs pass. **Certificate Metadata removal:** - It is gone from the agglayer and therefore it is not sent anymore from the aggsender either. - Only thing worth noting is that, when calculating `CertificateID`, instead of metadata field, which was used previously, we now use `ZeroHash`. **Smart contracts integration:** - **AggchainFEP contract:** Removed querying of `TrustedSequencer` address and rely on the signers committee instead - **AggchainBase contract:** Retrieve the multisig committee from the `AggchainBase` contract **Agglayer integration:** - Invoke the `GetNetworkState` API from agglayer to get the latest settled imported bridge exit info. - Multisig is populated into the certificate and sent to the Agglayer's `SendCertificate` gRPC endpoint ## ⚠️ Breaking Changes - 🛠️ **Config**: Make sure that `Mode` on the `Validator` and `AggSender` are the same. - 🔌 **API/CLI**: `aggkit` version (`v0.7.0`) that supports `multisig` will now require updated contracts to run. At least version `v12.1.0-rc.3` of `agglayer-contracts`, and a new version of `agglayer` which supports `multisig`, which is the `v0.4.0` of `agglayer`. - 🗑️ **Deprecated Features**: Aggsender Phase II validator signing logic ## 📋 Config Updates - Added `AggSender.RequireCommitteeMembershipCheck = false` parameter, which defines if a check on `aggsender proposer` startup will be performed to see if the proposer is in the `multisig` committee. - Added `Validator.RequireCommitteeMembershipCheck = {{AggSender.RequireCommitteeMembershipCheck}}` parameter, which defines if a check on `aggsender validator` startup will be performed to see if the validator is in the `multisig` committee. - Added `Validator.Mode = "PessimisticProof"` parameter, which acts the same as the `AggSender.Mode`. It tells the validator that the network is a `PP` network or an `FEP` network. It has to be the same as on `aggsender proposer`. - Added `Validator.FEPConfig.SovereignRollupAddr = "{{AggSender.SovereignRollupAddr}}" parameter which is the address of the `AggchainFEP` rollup on L1 for given network for which validator is running. - Added `Validator.FEPConfig.RequireNoBlockGap = {{AggSender.RequireNoFEPBlockGap}}, which acts the same as the given paremeter on `AggSender` (proposer) config, and tells the validator if gaps in blocks in certificates are allowed in `FEP` network. ```toml [AggSender] RequireCommitteeMembershipCheck = false [Validator] # PessimisticProof or AggchainProof Mode = "PessimisticProof" RequireCommitteeMembershipCheck = {{AggSender.RequireCommitteeMembershipCheck}} [Validator.FEPConfig] SovereignRollupAddr = "{{AggSender.SovereignRollupAddr}}" RequireNoBlockGap = "{{AggSender.RequireNoFEPBlockGap}}" ``` ## ✅ Testing - 🤖 **Automatic**: `aggkit` CI - 🖱️ **Manual**: [Optional: Steps to verify] ## 🐞 Issues - Closes #792 ## 🔗 Related PRs - #814 - #832 - #838 - #839 - #843 - #842 - #846 - #858 - #847 - #865 - #861 - #863 - #875 - #876 - #881 - #877 - #898 - #920 - #913 - #926 - #945 - #951 - #954 - #957 - #955 - #974 - #978 - #985 - #989 - #984 - #998 - #1017 - #1028 - #1034 - #1024 - #1052 - #1067 - #1068 - #1050 - #1071 - #1072 - #1060 - #1087 - #1077 - #1073 --------- Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Goran Rojovic <[email protected]> Co-authored-by: Joan Esteban <[email protected]> Co-authored-by: Rachit Sonthalia <[email protected]> Co-authored-by: Arpit Temani <[email protected]> Co-authored-by: Copilot <[email protected]>

Stefan-Ethernal self-assigned this Oct 2, 2025

Stefan-Ethernal marked this pull request as ready for review October 2, 2025 13:50

Stefan-Ethernal requested review from goran-ethernal and joanestebanr October 2, 2025 13:50

joanestebanr reviewed Oct 3, 2025

View reviewed changes

goran-ethernal reviewed Oct 3, 2025

View reviewed changes

sync/evmdownloader_test.go Outdated Show resolved Hide resolved

Stefan-Ethernal changed the title ~~fix: override block finality in evm downloader~~ fix: hardcode finalized block for bridge l1 syncer Oct 3, 2025

Stefan-Ethernal added 9 commits October 3, 2025 11:15

remove extra space

4528b70

reduce timeout in TestGetLogs

79ee8dd

in case finality is set to empty, override it to finalized blocks

3faf6b0

extract function and add unit test

4059ffd

simpplification and set to finalized block type in case it is empty

17f244f

update comment

ba343e5

override finality with finalized block type if empty

854b4dd

don't override the block finality, but return an error instead + cleanup

9114caa

rename

e954b19

Stefan-Ethernal force-pushed the fix/overriding-block-finality-in-evm-downloader branch from a534431 to e954b19 Compare October 3, 2025 09:15

fix unit tests

f80482e

Stefan-Ethernal requested review from goran-ethernal and joanestebanr October 3, 2025 10:12

Stefan-Ethernal changed the base branch from feat/fix_e2e_fep_v2 to feat/aggsender-multisig October 3, 2025 10:12

Stefan-Ethernal added 2 commits October 4, 2025 08:47

remove empty from block order

9a66e2a

ApplyOffset UT

0c89280

Stefan-Ethernal force-pushed the fix/overriding-block-finality-in-evm-downloader branch from d3ec811 to 0c89280 Compare October 4, 2025 06:47

goran-ethernal approved these changes Oct 6, 2025

View reviewed changes

Stefan-Ethernal added 2 commits October 6, 2025 10:52

remove redundant check from evm downloader

fec5ee9

renames and formatting

91bde70

Stefan-Ethernal requested a review from a team October 6, 2025 09:00

temaniarpit27 approved these changes Oct 6, 2025

View reviewed changes

rachit77 approved these changes Oct 6, 2025

View reviewed changes

joanestebanr reviewed Oct 7, 2025

View reviewed changes

sync/evmdownloader.go Show resolved Hide resolved

sync/evmdownloader.go Outdated Show resolved Hide resolved

joanestebanr approved these changes Oct 7, 2025

View reviewed changes

remove resolveBlockFinality function

b44e29f

Stefan-Ethernal merged commit ecdcd43 into feat/aggsender-multisig Oct 7, 2025
16 of 18 checks passed

Stefan-Ethernal deleted the fix/overriding-block-finality-in-evm-downloader branch October 7, 2025 09:54

goran-ethernal mentioned this pull request Oct 9, 2025

feat: Aggsender multisig #860

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: hardcode finalized block for bridge l1 syncer #1077

fix: hardcode finalized block for bridge l1 syncer #1077

Uh oh!

Stefan-Ethernal commented Oct 2, 2025 •

edited

Loading

Uh oh!

joanestebanr left a comment

Uh oh!

Stefan-Ethernal commented Oct 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

rachit77 left a comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fix: hardcode finalized block for bridge l1 syncer #1077

fix: hardcode finalized block for bridge l1 syncer #1077

Uh oh!

Conversation

Stefan-Ethernal commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔄 Changes Summary

⚠️ Breaking Changes

📋 Config Updates

✅ Testing

🐞 Issues

🔗 Related PRs

📝 Notes

Uh oh!

joanestebanr left a comment

Choose a reason for hiding this comment

Uh oh!

Stefan-Ethernal commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rachit77 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 7, 2025

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Stefan-Ethernal commented Oct 2, 2025 •

edited

Loading

Stefan-Ethernal commented Oct 3, 2025 •

edited

Loading