Rename on_domain_shutdown to avoid DispVM clobbering the function

[marmarek]

DispVM.on_domain_shutdown clobbers NetVMMixin.on_domain_shutdown. Rename
the latter to avoid that.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.51%. Comparing base (0be3631) to head (69b7afd).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #685   +/-   ##
=======================================
  Coverage   70.51%   70.51%           
=======================================
  Files          61       61           
  Lines       13312    13312           
=======================================
  Hits         9387     9387           
  Misses       3925     3925           

Flag	Coverage Δ
unittests	70.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025062018-4.3&flavor=pull-requests

Test run included the following:

• Add Arch packaging qubes-core-admin-client#332 (QubesOS/qubes-core-admin-client@40487bc)
• Preload dispvm dom0 feat qubes-core-admin-client#360 (QubesOS/qubes-core-admin-client@2447603)
• qvm-template: don't persist lock file across system reboots qubes-core-admin-client#366 (QubesOS/qubes-core-admin-client@c88036a)
• vmupdate: answer "yes" to the import key question qubes-core-admin-linux#194 (QubesOS/qubes-core-admin-linux@5ee0faa)
• Rename on_domain_shutdown to avoid DispVM clobbering the function #685 (69b7afd)
• Handle global disposable preload feature #686 (f13be7a)
• tests: adjust audio tests for changed recording stream behavior #688 (4571c3f)
• empty PR qubes-core-agent-linux#578 (QubesOS/qubes-core-agent-linux@66cbadf)
• Add handler for internal feature qubes-desktop-linux-menu#55 (QubesOS/qubes-desktop-linux-menu@933d7d3)
• Remove '$env' after it's loaded into environment qubes-gui-agent-linux#234 (QubesOS/qubes-gui-agent-linux@23a780f)
• Include 'pointer' in the qubes input device name qubes-gui-agent-linux#235 (QubesOS/qubes-gui-agent-linux@e14dc2e)
• pulse: connect recording stream only when recording is allowed qubes-gui-daemon#164 (QubesOS/qubes-gui-daemon@f596c69)
• Automatically accept test-signed driver installation qubes-installer-qubes-os-windows-tools#6 (QubesOS/qubes-installer-qubes-os-windows-tools@0b6a52a)
• Add Xen command line parsing qubes-linux-pvgrub2#16 (QubesOS/qubes-linux-pvgrub2@ea2ec7c)
• Replace numpy.fromstring with numpy.frombuffer qubes-linux-utils#127 (QubesOS/qubes-linux-utils@238dd4c)
• Ignore RemoteVM for now qubes-manager#398 (QubesOS/qubes-manager@679eff4)
• Add disposable preload setting to advanced settings qubes-manager#425 (QubesOS/qubes-manager@16f7bd0)
• Show (Manager App) Icons for Wayland/KDE qubes-manager#427 (QubesOS/qubes-manager@773a734)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

• system_tests_whonix

  • whonix_torbrowser: unnamed test (unknown)

  • whonix_torbrowser: Failed (test died)
    # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

  • whonix_torbrowser: unnamed test (unknown)

• system_tests_dispvm

  • TC_20_DispVM_debian-12-xfce: test_013_dvm_run_preload_gui (failure)
    ^... AssertionError: None is not true

  • TC_20_DispVM_fedora-42-xfce: test_013_dvm_run_preload_gui (failure)
    ^... AssertionError: None is not true

  • TC_20_DispVM_whonix-workstation-17: test_013_dvm_run_preload_gui (failure)
    ^... AssertionError: None is not true

• system_tests_basic_vm_qrexec_gui_zfs

  • TC_20_NonAudio_whonix-gateway-17-pool: test_400_long_window_title (error)
    subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...

• system_tests_audio

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: Failed to get mic attach/detach status!

• system_tests_update@hw13

  • update2: Failed (test died)
    # Test died: command 'script -c 'qubes-vm-update --force-update --l...

• system_tests_suspend@hw1

  • suspend: wait_serial (wait serial expected)
    # wait_serial expected: qr/9qnlY-\d+-/...

  • suspend: Failed (test died + timed out)
    # Test died: command 'qvm-run --no-gui -p sys-net "curl -f http://h...

Failed tests

14 failures

• system_tests_whonix

  • whonix_torbrowser: unnamed test (unknown)

  • whonix_torbrowser: Failed (test died)
    # Test died: no candidate needle with tag(s) 'tor-browser-ipcheck-o...

  • whonix_torbrowser: unnamed test (unknown)

• system_tests_extra

  • TC_00_QVCTest_whonix-workstation-17: test_010_screenshare (failure)
    AssertionError: 1 != 0 : Timeout waiting for /dev/video0 in test-in...

• system_tests_dispvm

  • TC_20_DispVM_debian-12-xfce: test_013_dvm_run_preload_gui (failure)
    ^... AssertionError: None is not true

  • TC_20_DispVM_fedora-42-xfce: test_013_dvm_run_preload_gui (failure)
    ^... AssertionError: None is not true

  • TC_20_DispVM_whonix-workstation-17: test_013_dvm_run_preload_gui (failure)
    ^... AssertionError: None is not true

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_basic_vm_qrexec_gui_zfs

  • TC_20_NonAudio_whonix-gateway-17-pool: test_400_long_window_title (error)
    subprocess.CalledProcessError: Command 'qubes.WaitForSession' retur...

• system_tests_audio

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: Failed to get mic attach/detach status!

• system_tests_update@hw13

  • update2: Failed (test died)
    # Test died: command 'script -c 'qubes-vm-update --force-update --l...

• system_tests_suspend@hw1

  • suspend: wait_serial (wait serial expected)
    # wait_serial expected: qr/9qnlY-\d+-/...

  • suspend: Failed (test died + timed out)
    # Test died: command 'qvm-run --no-gui -p sys-net "curl -f http://h...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

10 fixed

• system_tests_splitgpg

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_extra

  • TC_10_Thunderbird_whonix-workstation-17: test_000_send_receive_default (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_010_send_receive_inline_signed_only (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

  • TC_10_Thunderbird_whonix-workstation-17: test_020_send_receive_inline_with_attachment (failure)
    dogtail.tree.SearchError: descendent of [application | Thunderbird]...

• system_tests_guivm_vnc_gui_interactive

  • simple_gui_apps: unnamed test (unknown)
  • simple_gui_apps: Failed (test died)
    # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

• system_tests_audio

  • TC_20_AudioVM_Pulse_debian-12-xfce: test_252_audio_playback_audiovm_switch_hvm (failure)
    AssertionError: only silence detected, no useful audio data

  • TC_20_AudioVM_Pulse_whonix-workstation-17: test_225_audio_rec_unmuted_hvm (failure)
    AssertionError: too short audio, expected 10s, got 7.95233560090703...

Unstable tests

Performance Tests

Performance degradation:

8 performance degradations

• debian-12-xfce_exec-data-simplex: 77.16 🔺 ( previous job: 65.51, degradation: 117.78%)
• debian-12-xfce_exec-data-duplex-root: 79.51 🔺 ( previous job: 70.01, degradation: 113.57%)
• whonix-gateway-17_exec-data-duplex-root: 100.43 🔺 ( previous job: 90.74, degradation: 110.67%)
• whonix-workstation-17_exec-data-duplex-root: 102.97 🔺 ( previous job: 86.00, degradation: 119.73%)
• dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 9115.00 :small_red_triangle: ( previous job: 32696.00, degradation: 27.88%)
• dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 13915.00 :small_red_triangle: ( previous job: 17102.00, degradation: 81.36%)
• dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 9522.00 :small_red_triangle: ( previous job: 11086.00, degradation: 85.89%)
• dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 288.00 :small_red_triangle: ( previous job: 1840.00, degradation: 15.65%)

Remaining performance tests:

64 tests

• debian-12-xfce_exec: 5.56 🟢 ( previous job: 8.63, improvement: 64.39%)
• debian-12-xfce_exec-root: 28.85 🟢 ( previous job: 29.44, improvement: 98.00%)
• debian-12-xfce_socket: 8.32 🟢 ( previous job: 8.50, improvement: 97.88%)
• debian-12-xfce_socket-root: 8.95 🔺 ( previous job: 8.31, degradation: 107.68%)
• debian-12-xfce_exec-data-duplex: 74.69 🔺 ( previous job: 73.55, degradation: 101.56%)
• debian-12-xfce_socket-data-duplex: 166.04 🔺 ( previous job: 161.35, degradation: 102.91%)
• fedora-42-xfce_exec: 9.06
• fedora-42-xfce_exec-root: 58.08
• fedora-42-xfce_socket: 8.02
• fedora-42-xfce_socket-root: 8.75
• fedora-42-xfce_exec-data-simplex: 63.60
• fedora-42-xfce_exec-data-duplex: 74.22
• fedora-42-xfce_exec-data-duplex-root: 106.90
• fedora-42-xfce_socket-data-duplex: 154.77
• whonix-gateway-17_exec: 7.43 🔺 ( previous job: 7.34, degradation: 101.22%)
• whonix-gateway-17_exec-root: 42.42 🔺 ( previous job: 39.57, degradation: 107.18%)
• whonix-gateway-17_socket: 7.08 🟢 ( previous job: 7.85, improvement: 90.18%)
• whonix-gateway-17_socket-root: 8.63 🔺 ( previous job: 7.89, degradation: 109.35%)
• whonix-gateway-17_exec-data-simplex: 74.17 🟢 ( previous job: 77.76, improvement: 95.37%)
• whonix-gateway-17_exec-data-duplex: 78.39 🔺 ( previous job: 78.39, degradation: 100.00%)
• whonix-gateway-17_socket-data-duplex: 167.56 🔺 ( previous job: 161.95, degradation: 103.46%)
• whonix-workstation-17_exec: 8.51 🔺 ( previous job: 8.27, degradation: 102.88%)
• whonix-workstation-17_exec-root: 58.48 🔺 ( previous job: 57.61, degradation: 101.51%)
• whonix-workstation-17_socket: 9.34 🔺 ( previous job: 8.97, degradation: 104.15%)
• whonix-workstation-17_socket-root: 8.23 🟢 ( previous job: 9.46, improvement: 87.03%)
• whonix-workstation-17_exec-data-simplex: 79.01 🔺 ( previous job: 74.54, degradation: 106.00%)
• whonix-workstation-17_exec-data-duplex: 76.98 🔺 ( previous job: 74.84, degradation: 102.86%)
• whonix-workstation-17_socket-data-duplex: 145.44 🟢 ( previous job: 160.20, improvement: 90.79%)
• dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 313007.00 :green_circle: ( previous job: 289982.00, improvement: 107.94%)
• dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 168524.00 :green_circle: ( previous job: 101988.00, improvement: 165.24%)
• dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 74837.00 :green_circle: ( previous job: 14284.00, improvement: 523.92%)
• dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1822.00 :green_circle: ( previous job: 1091.00, improvement: 167.00%)
• dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 432938.00 :green_circle: ( previous job: 289182.00, improvement: 149.71%)
• dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 134287.00 :green_circle: ( previous job: 122848.00, improvement: 109.31%)
• dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 429392.00 :small_red_triangle: ( previous job: 433654.00, degradation: 99.02%)
• dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 183134.00 :green_circle: ( previous job: 167872.00, improvement: 109.09%)
• dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 103750.00 :small_red_triangle: ( previous job: 108760.00, degradation: 95.39%)
• dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 10420.00 :green_circle: ( previous job: 8874.00, improvement: 117.42%)
• dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8536.00 :green_circle: ( previous job: 6356.00, improvement: 134.30%)
• dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4391.00 :small_red_triangle: ( previous job: 4420.00, degradation: 99.34%)
• fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 368957.00
• fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 137153.00
• fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 287754.00
• fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 41883.00
• fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 80557.00
• fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2074.00
• fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8965.00
• fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1424.00
• fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 380746.00
• fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 118979.00
• fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 327884.00
• fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 63252.00
• fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 88016.00
• fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 3601.00
• fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 8591.00
• fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 1128.00
• fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 296459.00
• fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 95123.00
• fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 254446.00
• fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 102849.00
• fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 81262.00
• fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2296.00
• fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 7921.00
• fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 2192.00