Skip to content

Show (Manager App) Icons for Wayland/KDE #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Show (Manager App) Icons for Wayland/KDE #427

merged 1 commit into from
Jun 23, 2025

Conversation

@alimirjamali
Copy link
Contributor

@alimirjamali alimirjamali commented Jun 7, 2025

Without this, generic Wayland icon will be shown

@alimirjamali
Show (Manager App) Icons for Wayland/KDE
773a734 
Without this, generic Wayland icon will be shown
@alimirjamali
Copy link
Contributor Author

alimirjamali commented Jun 8, 2025

@marmarek The name of Qubes app object was not consistent with others in settings. I made a mistake there. The openQA tests need to be restarted.

This was referenced Jun 8, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
@qubesos-bot
Copy link

qubesos-bot commented Jun 8, 2025 •
edited
Loading

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025062114-4.3&flavor=pull-requests

Test run included the following:

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025061004-4.3&flavor=update

  • system_tests_dispvm

  • system_tests_kde_gui_interactive

    • kde_startup: unnamed test (unknown)
    • kde_startup: Failed (test died)
      # Test died: no candidate needle with tag(s) 'x11' matched...

  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-address-...

  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/dcWzE-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Failed tests

10 failures

  • system_tests_dispvm

  • system_tests_kde_gui_interactive

    • kde_startup: unnamed test (unknown)
    • kde_startup: Failed (test died)
      # Test died: no candidate needle with tag(s) 'x11' matched...

  • system_tests_qwt_win10@hw13

    • windows_install: Failed (test died)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

  • system_tests_qwt_win10_seamless@hw13

    • windows_clipboard_and_filecopy: unnamed test (unknown)
    • windows_clipboard_and_filecopy: Failed (test died)
      # Test died: no candidate needle with tag(s) 'windows-Edge-address-...

  • system_tests_qwt_win11@hw13

    • windows_install: wait_serial (wait serial expected)
      # wait_serial expected: qr/dcWzE-\d+-/...

    • windows_install: Failed (test died + timed out)
      # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/142375#dependencies

13 fixed

  • system_tests_splitgpg

  • system_tests_extra

  • system_tests_kde_gui_interactive

    • gui_keyboard_layout: wait_serial (wait serial expected)
      # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

    • gui_keyboard_layout: Failed (test died)
      # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

  • system_tests_guivm_vnc_gui_interactive

    • simple_gui_apps: unnamed test (unknown)
    • simple_gui_apps: Failed (test died)
      # Test died: no candidate needle with tag(s) 'vm-settings-applicati...

  • system_tests_audio

Unstable tests

Performance Tests

Performance degradation:

5 performance degradations
  • dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 10460.00 :small_red_triangle: ( previous job: 17102.00, degradation: 61.16%)
  • dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 90.00 :small_red_triangle: ( previous job: 1840.00, degradation: 4.89%)
  • debian-12-xfce_exec-data-simplex: 73.80 🔺 ( previous job: 65.51, degradation: 112.66%)
  • debian-12-xfce_exec-data-duplex-root: 85.52 🔺 ( previous job: 70.01, degradation: 122.16%)
  • whonix-workstation-17_exec-data-duplex-root: 98.45 🔺 ( previous job: 86.00, degradation: 114.47%)

Remaining performance tests:

67 tests
  • dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 490676.00 :green_circle: ( previous job: 289982.00, improvement: 169.21%)
  • dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 137827.00 :green_circle: ( previous job: 101988.00, improvement: 135.14%)
  • dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 83346.00 :green_circle: ( previous job: 14284.00, improvement: 583.49%)
  • dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 59598.00 :green_circle: ( previous job: 32696.00, improvement: 182.28%)
  • dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1431.00 :green_circle: ( previous job: 1091.00, improvement: 131.16%)
  • dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 11970.00 :green_circle: ( previous job: 11086.00, improvement: 107.97%)
  • dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 444500.00 :green_circle: ( previous job: 289182.00, improvement: 153.71%)
  • dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 135779.00 :green_circle: ( previous job: 122848.00, improvement: 110.53%)
  • dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 430449.00 :small_red_triangle: ( previous job: 433654.00, degradation: 99.26%)
  • dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 200756.00 :green_circle: ( previous job: 167872.00, improvement: 119.59%)
  • dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 104608.00 :small_red_triangle: ( previous job: 108760.00, degradation: 96.18%)
  • dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 9595.00 :green_circle: ( previous job: 8874.00, improvement: 108.12%)
  • dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 6662.00 :green_circle: ( previous job: 6356.00, improvement: 104.81%)
  • dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 4179.00 :small_red_triangle: ( previous job: 4420.00, degradation: 94.55%)
  • fedora-42-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 392725.00
  • fedora-42-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 280442.00
  • fedora-42-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 300107.00
  • fedora-42-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 121560.00
  • fedora-42-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 88255.00
  • fedora-42-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 1922.00
  • fedora-42-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 8507.00
  • fedora-42-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 527.00
  • fedora-42-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 378410.00
  • fedora-42-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 284861.00
  • fedora-42-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 319395.00
  • fedora-42-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 136942.00
  • fedora-42-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 71153.00
  • fedora-42-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 4044.00
  • fedora-42-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 7446.00
  • fedora-42-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 68.00
  • fedora-42-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 348364.00
  • fedora-42-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 164365.00
  • fedora-42-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 263991.00
  • fedora-42-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 126364.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 75987.00
  • fedora-42-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 2708.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8128.00
  • fedora-42-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1408.00
  • debian-12-xfce_exec: 6.03 🟢 ( previous job: 8.63, improvement: 69.83%)
  • debian-12-xfce_exec-root: 28.69 🟢 ( previous job: 29.44, improvement: 97.46%)
  • debian-12-xfce_socket: 8.59 🔺 ( previous job: 8.50, degradation: 101.07%)
  • debian-12-xfce_socket-root: 7.60 🟢 ( previous job: 8.31, improvement: 91.39%)
  • debian-12-xfce_exec-data-duplex: 67.54 🟢 ( previous job: 73.55, improvement: 91.83%)
  • debian-12-xfce_socket-data-duplex: 163.89 🔺 ( previous job: 161.35, degradation: 101.57%)
  • fedora-42-xfce_exec: 9.18
  • fedora-42-xfce_exec-root: 58.50
  • fedora-42-xfce_socket: 8.22
  • fedora-42-xfce_socket-root: 8.25
  • fedora-42-xfce_exec-data-simplex: 74.01
  • fedora-42-xfce_exec-data-duplex: 70.46
  • fedora-42-xfce_exec-data-duplex-root: 95.91
  • fedora-42-xfce_socket-data-duplex: 135.78
  • whonix-gateway-17_exec: 6.51 🟢 ( previous job: 7.34, improvement: 88.69%)
  • whonix-gateway-17_exec-root: 41.93 🔺 ( previous job: 39.57, degradation: 105.94%)
  • whonix-gateway-17_socket: 8.16 🔺 ( previous job: 7.85, degradation: 103.86%)
  • whonix-gateway-17_socket-root: 7.31 🟢 ( previous job: 7.89, improvement: 92.58%)
  • whonix-gateway-17_exec-data-simplex: 78.40 🔺 ( previous job: 77.76, degradation: 100.82%)
  • whonix-gateway-17_exec-data-duplex: 77.37 🟢 ( previous job: 78.39, improvement: 98.70%)
  • whonix-gateway-17_exec-data-duplex-root: 96.49 🔺 ( previous job: 90.74, degradation: 106.34%)
  • whonix-gateway-17_socket-data-duplex: 172.90 🔺 ( previous job: 161.95, degradation: 106.76%)
  • whonix-workstation-17_exec: 8.08 🟢 ( previous job: 8.27, improvement: 97.67%)
  • whonix-workstation-17_exec-root: 56.47 🟢 ( previous job: 57.61, improvement: 98.02%)
  • whonix-workstation-17_socket: 8.17 🟢 ( previous job: 8.97, improvement: 91.15%)
  • whonix-workstation-17_socket-root: 9.06 🟢 ( previous job: 9.46, improvement: 95.82%)
  • whonix-workstation-17_exec-data-simplex: 70.95 🟢 ( previous job: 74.54, improvement: 95.19%)
  • whonix-workstation-17_exec-data-duplex: 76.05 🔺 ( previous job: 74.84, degradation: 101.62%)
  • whonix-workstation-17_socket-data-duplex: 171.62 🔺 ( previous job: 160.20, degradation: 107.13%)

This was referenced Jun 8, 2025
Closed
Merged
Merged
Draft
Merged
Draft
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
@alimirjamali
Copy link
Contributor Author

alimirjamali commented Jun 14, 2025

@marmarek The unittest for this requires QubesOS/qubes-linux-utils#127 to pass

This was referenced Jun 18, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@alimirjamali
Copy link
Contributor Author

alimirjamali commented Jun 21, 2025

PipelineRetryFailed

@codecov
Copy link

codecov bot commented Jun 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 69.11%. Comparing base (bc659eb) to head (773a734).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
qubesmanager/backup.py 0.00% 1 Missing ⚠️
qubesmanager/qube_manager.py 0.00% 1 Missing ⚠️
qubesmanager/restore.py 0.00% 1 Missing ⚠️
qubesmanager/settings.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   69.08%   69.11%   +0.03%     
==========================================
  Files          17       17              
  Lines        3891     3895       +4     
==========================================
+ Hits         2688     2692       +4     
  Misses       1203     1203

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was referenced Jun 21, 2025
Merged
Merged
Merged
Merged
@marmarek marmarek merged commit 773a734 into QubesOS:main Jun 23, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marmarek marmarek marmarek approved these changes

Assignees

No one assigned

Labels

openqa-pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alimirjamali @qubesos-bot @marmarek