Skip to content

Rename on_domain_shutdown to avoid DispVM clobbering the function #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2025
Merged

Rename on_domain_shutdown to avoid DispVM clobbering the function #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion qubes/vm/dispvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ def on_domain_pre_unpaused(
@qubes.events.handler("domain-shutdown")
async def on_domain_shutdown(
self, _event, **_kwargs
): # pylint: disable=invalid-overridden-method
):
"""Do auto cleanup if enabled"""
await self._auto_cleanup()

Expand Down
2 changes: 1 addition & 1 deletion qubes/vm/mix/net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ def on_domain_load_netvm_loop_check(self, event):
self.netvm = None

@qubes.events.handler("domain-shutdown")
def on_domain_shutdown(self, event, **kwargs):
def on_domain_shutdown_net(self, event, **kwargs):
"""Cleanup network interfaces of connected, running VMs.

This will allow re-reconnecting them cleanly later.
Expand Down