re-order methods + code cleanup in imkl easyblock, tweaks for custom imkl-FFTW easyblock #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erfaces, get_interface_libs to get_mkl_fftw_interface_libs
…kl-FFTW interfaces through install_step rather than post_install_step, fix docstrings/comments
Author
|
Tested with easybuilders/easybuild-easyconfigs#14146 + a whole range of
|
bartoldeman
approved these changes
Oct 21, 2021
bartoldeman
left a comment
bartoldeman
left a comment
There was a problem hiding this comment.
Indeed, modulo the rearrangements it's a small diff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bartoldeman For easybuilders#2599
The diff for the
imkleasyblock looks scary, but that's mostly because I've re-ordered the methods in theimkleasyblock a bit, so they're in order of execution, and that methods likebuild_mkl_fftw_interfacesare defined before they get used (inpost_install_stepofimkleasyblock).