Skip to content

Conversation

@bartoldeman
Copy link
Contributor

The new imkl-fftw easyblock inherits imkl but bypasses the main portions of it, using only its interface building part.
To use those parts some the build and sanity check list were moved into new methods in the imkl easyblock.

Moved the interface build and sanity check library name list generator
into seperated methods instead of a long if block.

This allows calling those from other easyblocks (future imkl-fftw).
This inherits imkl but bypasses the main portions of it, using only
its interface building part.
@bartoldeman
Copy link
Contributor Author

Test report by @bartoldeman

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-2021.2.0-gompi-2021a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
build-node.computecanada.ca - Linux centos linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.7.7
See https://gist.github.com/9cb595021102041035e9d5b49a2fca50 for a full test report.

@boegel boegel added this to the 4.5.0 (next release) milestone Oct 16, 2021
@boegel boegel added the new label Oct 16, 2021
@bartoldeman
Copy link
Contributor Author

To actually use the FFTW MKL as seperate module in the framework a small change is needed there too (coming later)

@bartoldeman
Copy link
Contributor Author

Framework change: easybuilders/easybuild-framework#3861

@boegel boegel changed the title Implement new easyblock for installing MKL FFTW add custom easyblock for imkl-FFTW Oct 21, 2021
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartoldeman Some suggested changes in ComputeCanada#9

boegel and others added 2 commits October 21, 2021 11:18
re-order methods + code cleanup in imkl easyblock, tweaks for custom imkl-FFTW easyblock
@boegel
Copy link
Member

boegel commented Oct 21, 2021

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS imkl-11.3.1.150-iimpi-8.1.5-GCC-4.9.3-2.25.eb
  • SUCCESS imkl-2017.1.132-iimpi-2017a.eb
  • SUCCESS imkl-2018.1.163-iimpi-2018a.eb
  • SUCCESS imkl-2019.5.281-gompi-2019b.eb
  • SUCCESS imkl-2020.4.304-gompi-2020b.eb
  • SUCCESS imkl-2021.4.0-iimpi-2021.09.eb

Build succeeded for 6 out of 6 (6 easyconfigs in total)
node2692.swalot.os - Linux centos linux 7.9.2009, x86_64, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz (haswell), Python 3.6.8
See https://gist.github.com/cbd166d0d351b671cc376c85896e2948 for a full test report.

@boegel boegel merged commit d895488 into easybuilders:develop Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants