-
Notifications
You must be signed in to change notification settings - Fork 303
add custom easyblock for imkl-FFTW #2599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Moved the interface build and sanity check library name list generator into seperated methods instead of a long if block. This allows calling those from other easyblocks (future imkl-fftw).
This inherits imkl but bypasses the main portions of it, using only its interface building part.
|
Test report by @bartoldeman Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
|
To actually use the FFTW MKL as seperate module in the framework a small change is needed there too (coming later) |
|
Framework change: easybuilders/easybuild-framework#3861 |
…erfaces, get_interface_libs to get_mkl_fftw_interface_libs
…kl-FFTW interfaces through install_step rather than post_install_step, fix docstrings/comments
boegel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartoldeman Some suggested changes in ComputeCanada#9
re-order methods + code cleanup in imkl easyblock, tweaks for custom imkl-FFTW easyblock
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 6 out of 6 (6 easyconfigs in total) |
The new imkl-fftw easyblock inherits imkl but bypasses the main portions of it, using only its interface building part.
To use those parts some the build and sanity check list were moved into new methods in the imkl easyblock.