NXP LPSPI: Some bug fixes to the interrupt-based driver #86889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For multi-byte word, there is clearly a bug in that the same byte is written to each spot in the word instead of writing all the bytes properly. Signed-off-by: Declan Snyder <[email protected]>
There is a bug here clearly which is that if there is some error in the transceive function, it returns without releasing the context. This should be fixed by properly handling the errors with a context release before returning. Signed-off-by: Declan Snyder <[email protected]>
zephyrbot
added
platform: NXP Drivers
zephyrbot
requested review from
Raymond0225,
dbaluta,
dleach02,
manuargue,
mmahadevan108,
tbursztyka and
teburd
Raymond0225
approved these changes
Mar 10, 2025
decsny
added
backport v4.1-branch
mmahadevan108
approved these changes
Mar 14, 2025
dleach02
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs I saw while doing code analysis:
Fixes #86930