Skip to content

libc: Default to picolibc where supported #57340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 4, 2023
Merged

libc: Default to picolibc where supported #57340

merged 2 commits into from
Sep 4, 2023

Conversation

@keith-packard
Copy link
Contributor

@keith-packard keith-packard commented Apr 27, 2023 •
edited by stephanosio
Loading

This switches the default C library to picolibc for all targets which support it.

Closes #49922

@keith-packard keith-packard added area: C Library C Standard Library DNM This PR should not be merged (Do Not Merge) area: picolibc Picolibc C Standard Library labels Apr 27, 2023
@keith-packard keith-packard requested a review from nashif as a code owner April 27, 2023 13:33
@carlescufi carlescufi added the TSC Topics that need TSC discussion label Apr 27, 2023
@carlescufi
Copy link
Member

@keith-packard labeling this as TSC since this requires a bit more discussion.

@stephanosio stephanosio mentioned this pull request Apr 27, 2023
Closed
60 tasks
@zephyrbot zephyrbot added area: TF-M ARM Trusted Firmware-M (TF-M) area: Userspace Userspace labels Apr 27, 2023
@zephyrbot zephyrbot requested review from ceolin and joerchan April 27, 2023 15:56
@zephyrbot
Copy link

zephyrbot commented Apr 27, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
mcuboot zephyrproject-rtos/mcuboot@1558e7a (main) zephyrproject-rtos/mcuboot@2878eb4 (upstream-sync) zephyrproject-rtos/[email protected]
picolibc zephyrproject-rtos/picolibc@93b5d5f (main) zephyrproject-rtos/picolibc@zephyr-source zephyrproject-rtos/[email protected]
sof zephyrproject-rtos/sof@ffbf9c2 (zephyr) zephyrproject-rtos/sof#28 zephyrproject-rtos/sof#28/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@marc-hb
Copy link
Contributor

marc-hb commented May 1, 2023 •
edited
Loading

One of the commit messages is:

modules/audio/sof: Pull fix for main return type

Upstream PR #28 switches return type of 'main' to 'int'.

Signed-off-by: Keith Packard [email protected]

Pull request 28 does not seem related. It's from 2017 :-)

EDIT: got it, you meant zephyrproject-rtos/sof/pull/28, not #28

Could you please share a link with more information about this change of the main prototype? It seems related to picolibc but so are many other changes so it does not narrow it down.

Screenshot 2023-05-01 at 10 20 17

@keith-packard
Copy link
Contributor Author

EDIT: got it, you meant zephyrproject-rtos/sof/pull/28, not #28

Sorry for the mis-leading link.

Could you please share a link with more information about this change of the main prototype? It seems related to picolibc but so are many other changes so it does not narrow it down.

Yeah, this is only vaguely related to picolibc itself -- as a complete C library, it's best to compile applications using picolibc without the -ffreestanding compiler flag as that improves code generation and error detection. But, with that option not present, clang makes mis-matching main type a fatal error. So, that means we needed to switch the return type to int. That series, #54628 was merged a while ago.

evgeniy-paltsev
evgeniy-paltsev previously requested changes May 3, 2023
View reviewed changes
keith-zephyr
keith-zephyr reviewed May 3, 2023
View reviewed changes
@stephanosio
Copy link
Member

As per #49922 (comment), this needs more documentation and process-related work before it can be approved by the TSC.

I will look into that and create a new PR based on this with the necessary changes.

@keith-packard keith-packard mentioned this pull request Aug 24, 2023
Closed
@nashif nashif dismissed evgeniy-paltsev’s stale review August 29, 2023 16:25

Can you please re-review?

@nashif nashif removed the TSC Topics that need TSC discussion label Sep 4, 2023
nashif
nashif reviewed Sep 4, 2023
View reviewed changes
lib/libc/Kconfig
default PICOLIBC
default NEWLIB_LIBC if REQUIRES_FULL_LIBC
default PICOLIBC if REQUIRES_FULL_LIBC
default MINIMAL_LIBC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we end up with both picolibc and minimal libc set as default? or does order here play a role?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kconfig appears to pick the first which matches and which can be enabled -- the goal is to use picolibc where supported otherwise use minimal C library.

@carlescufi
Copy link
Member

@keith-packard, now that we have a migration guide, would you mind adding a note there? I assume under "Required changes", given that users may see their applications break depending on what they are using?

@keith-packard
Copy link
Contributor Author

@keith-packard, now that we have a migration guide, would you mind adding a note there? I assume under "Required changes", given that users may see their applications break depending on what they are using?

#62261 has some possible things to check. I'm not sure how these should be integrated into the rest of the migration notes though.

@nashif nashif merged commit 844c78c into zephyrproject-rtos:main Sep 4, 2023
@keith-packard keith-packard deleted the picolibc-default branch September 4, 2023 20:13
@fabiobaltieri fabiobaltieri mentioned this pull request Sep 4, 2023
Merged
@glarsennordic glarsennordic mentioned this pull request Sep 6, 2023
Merged
@SgrrZhf SgrrZhf mentioned this pull request Sep 8, 2023
Merged
@SgrrZhf SgrrZhf mentioned this pull request Sep 8, 2023
Merged
SgrrZhf added a commit to SgrrZhf/zephyr that referenced this pull request Sep 11, 2023
@SgrrZhf
tests: net: lib: lwm2m: fix the missing float support
5a1a1fe 
The tests `content_json` and `content_plain_test` depend on the float
support of libc. After PR#zephyrproject-rtos#57340, Picolibc would be selected in
these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if
the platform doesn't select `FPU`.

This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT`
for these two tests.

Signed-off-by: Huifeng Zhang <[email protected]>
nashif pushed a commit that referenced this pull request Sep 11, 2023
@SgrrZhf @nashif
tests: net: lib: lwm2m: fix the missing float support
662a14a 
The tests `content_json` and `content_plain_test` depend on the float
support of libc. After PR##57340, Picolibc would be selected in
these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if
the platform doesn't select `FPU`.

This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT`
for these two tests.

Signed-off-by: Huifeng Zhang <[email protected]>
@feilongfl feilongfl mentioned this pull request Sep 11, 2023
Closed
joerchan pushed a commit to joerchan/zephyr that referenced this pull request Oct 2, 2023
@SgrrZhf @de-nordic
[nrf fromtree] tests: net: lib: lwm2m: fix the missing float support
fb04730 
The tests `content_json` and `content_plain_test` depend on the float
support of libc. After PR#zephyrproject-rtos#57340, Picolibc would be selected in
these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if
the platform doesn't select `FPU`.

This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT`
for these two tests.

Signed-off-by: Huifeng Zhang <[email protected]>
(cherry picked from commit 5a1a1fe)
Signed-off-by: Dominik Ermel <[email protected]>
theob-pro pushed a commit to theob-pro/zephyr that referenced this pull request Oct 23, 2023
@SgrrZhf @cvinayak
[nrf fromtree] tests: net: lib: lwm2m: fix the missing float support
61e999d 
The tests `content_json` and `content_plain_test` depend on the float
support of libc. After PR#zephyrproject-rtos#57340, Picolibc would be selected in
these two tests and the `PICOLIBC_IO_FLOAT` won't be selected if
the platform doesn't select `FPU`.

This commit select `CONFIG_PICOLIBC` and `CONFIG_PICOLIBC_IO_FLOAT`
for these two tests.

Signed-off-by: Huifeng Zhang <[email protected]>
(cherry picked from commit 5a1a1fe)
Signed-off-by: Dominik Ermel <[email protected]>
(cherry picked from commit fb04730)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keith-zephyr keith-zephyr keith-zephyr left review comments

@nashif nashif nashif approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@cfriedt cfriedt cfriedt approved these changes

@tejlmand tejlmand tejlmand approved these changes

@stephanosio stephanosio Awaiting requested review from stephanosio

@microbuilder microbuilder Awaiting requested review from microbuilder

@ceolin ceolin Awaiting requested review from ceolin

@andyross andyross Awaiting requested review from andyross

@jhedberg jhedberg Awaiting requested review from jhedberg

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@kgugala kgugala Awaiting requested review from kgugala

@pgielda pgielda Awaiting requested review from pgielda

@carlocaione carlocaione Awaiting requested review from carlocaione

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@ioannisg ioannisg Awaiting requested review from ioannisg

@abrodkin abrodkin Awaiting requested review from abrodkin

@ruuddw ruuddw Awaiting requested review from ruuddw

@evgeniy-paltsev evgeniy-paltsev Awaiting requested review from evgeniy-paltsev

Assignees

@stephanosio stephanosio

Labels

area: C Library C Standard Library area: Device Model area: Kernel area: picolibc Picolibc C Standard Library area: TF-M ARM Trusted Firmware-M (TF-M) area: Userspace Userspace area: X86 x86 Architecture (32-bit) manifest manifest-mcuboot manifest-picolibc manifest-sof

Projects

TSC Attention Needed
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make picolibc the default C library for Zephyr