Skip to content

Conversation

lpereira
Copy link
Member

@lpereira lpereira commented May 1, 2017

These patches were already +2's by Jukka and Tomasz in Gerrit:


This change is Reviewable

@jukkar
Copy link
Member

jukkar commented May 2, 2017

Please remove the Change-Id fields from commits, they are not needed in github.

This is related to commit "net: tcp: Make sure ACK timer is not
run if cancelled" which did not set the cancel flag when the timer
was cancelled from tcp.c.

Signed-off-by: Jukka Rissanen <[email protected]>
@tbursztyka tbursztyka self-requested a review May 2, 2017 07:35
When adding link-local address to the cache the type needs to be
properly set as net_ipv6_addr_create_iid will attempt to use it
when generating the IPv6 address.

Jira: ZEP-2077
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
@jukkar jukkar self-requested a review May 3, 2017 07:46
jukkar
jukkar previously requested changes May 3, 2017
Copy link
Member

@jukkar jukkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the Change-Id fields from commit msg.

lpereira added 2 commits May 3, 2017 12:21
The main difference to how the previous driver operates, is that this
version has zero-copy transmission.  The transmit DMA descriptor is
updated for every fragment that is transmitted from the driver.

Another difference in the transmission path is that this version won't
spin indefinitely while waiting for the DMA transfer to complete; an
arbitrary number of busy checks (20) will be performed, and then
the transmission thread will yield for as long as necessary to finish
the transfer.

These two changes should fix ZEP-472; since that issue was opened for
an older version of Zephyr with uIP, I did not bother going all the way
back to test.

This has been only tested with a Galileo board, using Shared IRQ.

Jira: ZEP-1652
Jira: ZEP-472
Signed-off-by: Leandro Pereira <[email protected]>
Enable it by default now that the eth_dw driver has been ported to the
new IP stack.

Jira: ZEP-1652
Signed-off-by: Leandro Pereira <[email protected]>
@jukkar jukkar changed the base branch from net to master May 3, 2017 20:15
@nashif nashif dismissed jukkar’s stale review May 4, 2017 15:57

already done

@nashif nashif merged commit d260fe2 into zephyrproject-rtos:master May 4, 2017
frasa added a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
fix: radio: fixed low power race condition on TX

Closes zephyrproject-rtos#28

See merge request blik/embedded/zephyr!39
NickolasLapp pushed a commit to NickolasLapp/zephyr that referenced this pull request Oct 19, 2022
keith-packard added a commit to keith-packard/zephyr that referenced this pull request Apr 28, 2023
Upstream PR zephyrproject-rtos#28 switches return type of 'main' to 'int'.

Signed-off-by: Keith Packard <[email protected]>
keith-packard added a commit to keith-packard/zephyr that referenced this pull request Apr 28, 2023
Upstream PR zephyrproject-rtos#28 switches return type of 'main' to 'int'.

Signed-off-by: Keith Packard <[email protected]>
keith-packard added a commit to keith-packard/zephyr that referenced this pull request May 30, 2023
Upstream PR zephyrproject-rtos#28 switches return type of 'main' to 'int'.

Signed-off-by: Keith Packard <[email protected]>
keith-packard added a commit to keith-packard/zephyr that referenced this pull request Jun 16, 2023
Upstream PR zephyrproject-rtos#28 switches return type of 'main' to 'int'.

Signed-off-by: Keith Packard <[email protected]>
pkunieck pushed a commit to pkunieck/zephyr that referenced this pull request Jul 18, 2023
- Bump SDK version to 0.14.2
- Add docker rmi || tru fix for image disk leak on multiple rebuilds to
1rtos-container-image-build.yml
- Drop awscli pip install. It required docutils = 0.16 or lower, which
breaks docs packages like sphinx and others.
- Bump the six and jinja2 versions. Defaults are too old break other
packages.
- Pin docutils at 17 which is mutally compatible with everything.
Default is 0.18.1, which hoses things.
- Add the doxygen installation from upstream project docker image.
- Downgrade the protobuf version to make samples/modules/nanopb happy.
Versions over 3.19.0 break the generated .proto stuff. Will open a bug
upstream on that.
- See zephyrproject-rtos/docker-image#106 for
related issue on the dependency issues (not including protobuf nanopb
thing).

Signed-off-by: Connor Graydon <[email protected]>
fouge added a commit to worldcoin/zephyr that referenced this pull request Apr 2, 2025
the remote (in our case the Nvidia Jetson) seems to have trouble sending
 messages over iso-tp in specific cases
using candump, we can see that the flow-control (FC) frame is received
before the last frame from the block (bs=8) is sent, which is not
expected.

A dump:
```
can0  3F2 [8]  27 2C 2D 2E 2F 30 31 32  <- frame zephyrproject-rtos#27 = 7/8
can0  1F2 [3]  30 08 00                 <- FC frame
can0  3F2 [8]  28 33 34 35 36 37 38 39  <- frame zephyrproject-rtos#28 = 8/8
```

Probing the can bus, we can see that frame zephyrproject-rtos#28 is sent before the FC
frame is responded to the Jetson (as per iso-tp protocol).
But the Jetson doesn't seem to correctly order these frames and each
time it happens, transmission stalls.

Adding some delay for the FC response on the mcu side seems to fix the
issue as the Jetson now has more time to set up the reception of the FC
frame.

Signed-off-by: Cyril Fougeray <[email protected]>
MuhammedZamroodh pushed a commit to Zephyr4Microchip/zephyr that referenced this pull request Aug 5, 2025
Added support of west flash for dspic33a_curiosity board.
Added support of twister for dspic33a_curiosity board.

Signed-off-by: Adhil Xavier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants