refactor(component pages): reference updated subComponents' displayName
#621
Conversation
| <Field.Hint /> | ||
| <InputGroup /> | ||
| </Field> | ||
| ``` |
There was a problem hiding this comment.
Should the InputGroup page display Field's APIs?
There was a problem hiding this comment.
I think there was a concern about Field taking API prominence. We can probably leave it off here.
| #### Nav.List | ||
|
|
||
| <Component components={props.data.mdx.components} componentName="navItemText" /> | ||
| <Component components={props.data.mdx.subcomponents} componentName="nav" /> |
There was a problem hiding this comment.
Looks like zendeskgarden/react-components#1883 missed one. 😢
TODO: Update to nav.list once fixed.
| A Field provides accessibility attributes to its child [Textarea](#textarea) field by associating it | ||
| with the corresponding [Label](#label) and [Hint](/components/input#hint). | ||
| A Field provides accessibility attributes to its child [Textarea](#textarea) field by | ||
| associating it with the corresponding [Field.Label](#fieldlabel) and [Field.Hint](#fieldhint). |
There was a problem hiding this comment.
MarkdownLint required a line break.
src/pages/components/chrome.mdx
Outdated
| #### Header.ItemText | ||
|
|
||
| <Component components={props.data.mdx.components} componentName="headerItemText" /> | ||
| <Component components={props.data.mdx.subcomponents} componentName="header.itemtext" /> |
There was a problem hiding this comment.
[supernit] even though the componentName is case insensitive, it would be consistent to keep the camelCase here. header.itemIcon, header.itemText, etc. Not critical for merge, though.
|
@ze-flo can the disabled deprecation rule be removed from |
…ubcomponents-displayname # Conflicts: # package-lock.json # package.json
| "lint": "npm run lint:js && npm run lint:css && npm run lint:md", | ||
| "lint:css": "stylelint 'src/**/*.{js,ts,tsx}'", | ||
| "lint:js": "eslint ./ --max-warnings 0", | ||
| "lint:js": "eslint ./", |
There was a problem hiding this comment.
At this point, they are still 716 deprecation warnings that will be addressed in future PRs. Temporarily removing the --max-warning flag for now.
There was a problem hiding this comment.
That feel like a good trade-off – keeps em in our face
Description
References updated subComponents'
displayNameto pullpropsinfo.Detail
next@zendeskgarden deps to latestnextreleasereact-componentssubmodule to latestnexttagdisplayNameChecklist
👌 website updates are Garden Designer approved (add the designer as a reviewer)✒️ copy updates are approved (add the content strategist as a reviewer)🔗 considered opportunities for adding cross-reference URLs (grep for keywords)♿ analyzed via axe and evaluated using VoiceOver📝 tested in Chrome, Firefox, Safari, Edge