Skip to content

Conversation

geotrev
Copy link
Contributor

@geotrev geotrev commented Aug 8, 2024

Description

Catches several components' displayName properties to match corresponding subcomponent mapping. Follows migration guide for targeted components.

Detail

Separately:

  • Removed export on OffsetPaginationComponent
  • Copies Close, Title, and Paragraph subcomponents under react-notifications to be applied in Well, Alert and Notification with unique/non-shared displayName values. Folder structure mirrors existing packages with similar subcomponent mappings, namely react-modals.
    • Leaves existing deprecation text for V8 standalone subcomponent exports

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, I guess there was more here than we expected 😅. Reminder to run npx garden cmd-docgen --pretty against key files as an extra check to verify that @extends clause and naming are lining up as expected.

@geotrev
Copy link
Contributor Author

geotrev commented Aug 8, 2024

Whoa, I guess there was more here than we expected 😅. Reminder to run npx garden cmd-docgen --pretty against key files as an extra check to verify that @extends clause and naming are lining up as expected.

Good call, from what I can tell the new files look correct.

CursorPagination also appears to populate its @extends field correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants