Skip to content

feat(pagination): deprecate PaginationContainer and migrate to container-pagination #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2019
Merged

feat(pagination): deprecate PaginationContainer and migrate to container-pagination #453

merged 4 commits into from
Sep 13, 2019

Conversation

@austingreendev
Copy link
Contributor

@austingreendev austingreendev commented Sep 13, 2019 •
edited
Loading

Description

This PR deprecates the PaginationContainer component and migrates usage to the PaginationContainer from container-pagination.

This PR also updates all container-* packages across the repo.

Detail

Closes #436

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@austingreendev austingreendev requested a review from a team September 13, 2019 15:54
@coveralls
Copy link

coveralls commented Sep 13, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.7%) to 94.941% when pulling 3cd20a7 on agreen/deprecate-pagination-container into 80b60dc on master.

jzempel
jzempel approved these changes Sep 13, 2019
View reviewed changes
@austingreendev austingreendev merged commit c4cbe0d into master Sep 13, 2019
@austingreendev austingreendev deleted the agreen/deprecate-pagination-container branch September 13, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jzempel jzempel jzempel approved these changes

Assignees

No one assigned

Labels

PR: New Feature 🚀

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@austingreendev @coveralls @jzempel