Skip to content

Conversation

@ryanseddon
Copy link
Contributor

  • BREAKING CHANGE?

Description

Migration <Pagination> to container-pagination hook

Detail

This is still a WIP basic functionality still works but has some glaring bugs that just need to be worked through.

Its breaking as we seperate the state changes between two callbacks onSelect and onFocus in the hooks world. So the props passed into <Pagination> should be those rather than onChange and onStateChange.

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 💅 view component styling is based on a Garden CSS
    component
  • 🌐 Styleguidist demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants