-
Notifications
You must be signed in to change notification settings - Fork 97
feat(dropdowns): introduce Multiselect component #439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| { | ||
| "*.{js,ts,tsx}": [ | ||
| "stylelint", | ||
| "eslint", | ||
| "jest --config=utils/test/jest.config.js --findRelatedTests", | ||
| "prettier --write", | ||
| "git add" | ||
| ], | ||
| "!(*CHANGELOG).md": [ | ||
| "markdownlint", | ||
| "prettier --write", | ||
| "git add" | ||
| ], | ||
| "**/package.json": [ | ||
| "prettier-package-json --write", | ||
| "git add" | ||
| ] | ||
| } |
This file was deleted.
Oops, something went wrong.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,138 @@ | ||
| The `Multiselect` component renders a customizable "tag" for each selected item. | ||
|
|
||
| This can be any element, but the surrounding field is designed to work with | ||
| our standard `Tag` component. | ||
|
|
||
| ```jsx static | ||
| <Dropdown> | ||
| <Field> | ||
| <Label>Example Multiselect</Label> | ||
| <Multiselect | ||
| renderItem={({ value, removeValue }) => ( | ||
| <Tag size="large"> | ||
| {value} <Close onClick={() => removeValue()} /> | ||
| </Tag> | ||
| )} | ||
| /> | ||
| </Field> | ||
| <Menu>{/** customizable items **/}</Menu> | ||
| </Dropdown> | ||
| ``` | ||
|
|
||
| ```js | ||
| const debounce = require('lodash.debounce'); | ||
| const { Tag, Close } = require('@zendeskgarden/react-tags/src'); | ||
|
|
||
| const options = [ | ||
| 'Aster', | ||
| "Bachelor's button", | ||
| 'Celosia', | ||
| 'Dusty miller', | ||
| 'Everlasting winged', | ||
| "Four o'clock", | ||
| 'Geranium', | ||
| 'Honesty', | ||
| 'Impatiens', | ||
| 'Johnny jump-up', | ||
| 'Kale', | ||
| 'Lobelia', | ||
| 'Marigold', | ||
| 'Nasturtium', | ||
| 'Ocimum (basil)', | ||
| 'Petunia', | ||
| 'Quaking grass', | ||
| 'Rose moss', | ||
| 'Salvia', | ||
| 'Torenia', | ||
| 'Ursinia', | ||
| 'Verbena', | ||
| 'Wax begonia', | ||
| 'Xeranthemum', | ||
| 'Yellow cosmos', | ||
| 'Zinnia' | ||
| ]; | ||
|
|
||
| function ExampleAutocomplete() { | ||
| const [selectedItems, setSelectedItems] = React.useState([ | ||
| options[0], | ||
| options[1], | ||
| options[2], | ||
| options[3], | ||
| options[4], | ||
| options[5] | ||
| ]); | ||
| const [inputValue, setInputValue] = React.useState(''); | ||
| const [isLoading, setIsLoading] = React.useState(false); | ||
| const [matchingOptions, setMatchingOptions] = React.useState(options); | ||
|
|
||
| /** | ||
| * Debounce filtering | ||
| */ | ||
| const filterMatchingOptionsRef = React.useRef( | ||
| debounce(value => { | ||
| const matchingOptions = options.filter(option => { | ||
| return ( | ||
| option | ||
| .trim() | ||
| .toLowerCase() | ||
| .indexOf(value.trim().toLowerCase()) !== -1 | ||
| ); | ||
| }); | ||
|
|
||
| setMatchingOptions(matchingOptions); | ||
| setIsLoading(false); | ||
| }, 300) | ||
| ); | ||
|
|
||
| React.useEffect(() => { | ||
| setIsLoading(true); | ||
| filterMatchingOptionsRef.current(inputValue); | ||
| }, [inputValue]); | ||
|
|
||
| const renderOptions = () => { | ||
| if (isLoading) { | ||
| return <Item disabled>Loading items...</Item>; | ||
| } | ||
|
|
||
| if (matchingOptions.length === 0) { | ||
| return <Item disabled>No matches found</Item>; | ||
| } | ||
|
|
||
| return matchingOptions.map(option => ( | ||
| <Item key={option} value={option}> | ||
| <span>{option}</span> | ||
| </Item> | ||
| )); | ||
| }; | ||
|
|
||
| return ( | ||
| <Dropdown | ||
| inputValue={inputValue} | ||
| selectedItems={selectedItems} | ||
| onSelect={items => setSelectedItems(items)} | ||
| downshiftProps={{ defaultHighlightedIndex: 0 }} | ||
| onStateChange={changes => { | ||
| if (Object.prototype.hasOwnProperty.call(changes, 'inputValue')) { | ||
| setInputValue(changes.inputValue); | ||
| } | ||
| }} | ||
| > | ||
| <Field> | ||
| <Label>Multiselect with debounce</Label> | ||
| <Hint>This example includes basic debounce logic</Hint> | ||
| <Multiselect | ||
| small | ||
austingreendev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| renderItem={({ value, removeValue }) => ( | ||
austingreendev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <Tag> | ||
| {value} <Close onClick={() => removeValue()} /> | ||
| </Tag> | ||
| )} | ||
| /> | ||
| </Field> | ||
| <Menu small>{renderOptions()}</Menu> | ||
| </Dropdown> | ||
| ); | ||
| } | ||
|
|
||
| <ExampleAutocomplete />; | ||
| ``` | ||
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.