feat(dropdowns): introduce Multiselect component #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingreendev
force-pushed
the
agreen/multiselect
branch
from
301968c to
502c5a4
Compare
|
Coveralls now has a corrected coverage https://coveralls.io/builds/25638668 |
ryanseddon
reviewed
Sep 11, 2019
jzempel
requested changes
Sep 12, 2019
| `} | ||
| `; | ||
|
|
||
| export const StyledMoreAnchor = styled.div` |
There was a problem hiding this comment.
Sadness that we can't modify our StyledAnchor here. 🙁
austingreendev
force-pushed
the
agreen/multiselect
branch
from
502c5a4 to
cd3b56b
Compare
jzempel
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
Multiselectcomponent within thereact-dropdownspackage. This is the final item necessary to finalize thereact-autocompletedeprecation.Detail
This component has a similar API to the previous element. It also includes the complications of that design so this isn't the most elegant solution. This component is starting to stretch the "global"
<Dropdown>API that is shared with Menu, Select, and Autocomplete.Downshift is working on a collection of hooks that would replicate what we have achieved in
react-dropdowns. Hopefully we can transition to those once they are fleshed out some more.Checklist
designer as a reviewer)
component
yarn start)