Skip to content

Conversation

@jzempel
Copy link
Member

@jzempel jzempel commented Oct 16, 2024

Description

This PR addresses a smattering of issues and cleanup with the v9 codebase.

🐛 Fixes

  • override browser UA opacity styling for native Select (uncovered during css-components refactor)
  • @extends documentation for Table

🌱 Internal

  • remove non-functioning size snapshot testing from the build
  • restructure internal MessageIcon to follow proper Garden view-element component conventions

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

@coveralls
Copy link

Coverage Status

coverage: 95.895% (-0.008%) from 95.903%
when pulling 620600c on jzempel/misc-fix
into 3cb8cab on main.

Copy link
Contributor

@ze-flo ze-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor and clean up. 🧼 💯

I'll pull the changes into #1952 and resolve the conflicts after this merges. 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jzempel jzempel merged commit 30e06b0 into main Oct 16, 2024
9 checks passed
@jzempel jzempel deleted the jzempel/misc-fix branch October 16, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants