Skip to content

Conversation

@ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Oct 2, 2024

Description

Replaces invalid <div> from Table OverflowButton w/ <span>

Detail

Checklist

  • 👌 design updates will be Garden Designer approved (add the designer as a reviewer)
  • 🌐 demo is up-to-date (npm start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • ⚫ renders as expected in dark mode
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • 💂‍♂️ includes new unit tests. Maintain existing coverage (always >= 96%)
  • ♿ tested for WCAG 2.1 AA accessibility compliance
  • 📝 tested in Chrome, Firefox, Safari, and Edge

Copy link
Member

@jzempel jzempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of bookkeeping are you able to reference the v9 PR in the PR description?

@ze-flo
Copy link
Contributor Author

ze-flo commented Oct 3, 2024

For the sake of bookkeeping are you able to reference the v9 PR in the PR description?

There's no direct equivalent. Removing the invalid <div> was a side-effect from (breaking) changes made to the OverflowButton in #1833.

@ze-flo ze-flo merged commit 771fbc5 into v8 Oct 3, 2024
7 of 8 checks passed
@ze-flo ze-flo deleted the ze-flo/table-overflow-fix branch October 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants