feat(loaders): allow color props to receive color variable keys in addition to hex values #1926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ze-flo
reviewed
Sep 24, 2024
| } | ||
|
|
||
| const colorStyles = ({ theme, color }: IStyledInlineProps & ThemeProps<DefaultTheme>) => { | ||
| const options = color.includes('.') ? { variable: color, theme } : { hue: color, theme }; |
There was a problem hiding this comment.
To double-check, we do not support rgba colors (rgba(123,43,56, 0.5). Correct?
[update]: rgba shouldn't be supported.
| return !!parseToRgba(maybeColor); | ||
| } catch { | ||
| return false; | ||
| let retVal = ['currentcolor', 'inherit', 'transparent'].includes(maybeColor); |
ze-flo
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-on from #1885 that rounds out color variable prop treatment for
loaders.Detail
Improves
getColorto allow forinheritandcurrentcolorkeywords in addition totransparent(which is already supported).Checklist
npm start)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock)tested for WCAG 2.1 AA accessibility compliance