feat: allow color-related props to receive color variable keys in addition to hex values #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geotrev
approved these changes
Aug 14, 2024
| } | ||
|
|
||
| if ($foregroundColor) { | ||
| foregroundColor = $foregroundColor.includes('.') |
There was a problem hiding this comment.
This feels like it might be overkill, but would we benefit from a utility function from the theming package?
const parseColorProp = (value) => value.includes('.') ? getColor({ theme, variable: value }) : value
// in component:
const foregroundColor = parseColorProp($foregroundColor)
| } | ||
|
|
||
| return css` | ||
| transition: color 0.1s ease-in-out; |
ze-flo
approved these changes
Aug 14, 2024
1 task
8 tasks
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates related prop documentation and sets the following props to be able to receive color variable key strings:
surfaceColorbackgroundColorforegroundColorsurfaceColorhueDetail
Tagis a description update only as the primaryhuecolors already received intended light/dark treatment.Checklist
design updates will be Garden Designer approved (add the designer as a reviewer)npm start)renders as expected with reversed (RTL) directionrenders as expected with Bedrock CSS (?bedrock)tested for WCAG 2.1 AA accessibility compliancetested in Chrome, Firefox, Safari, and Edge