Bring v2 up to date with current changes on master #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the [doc](https://docs.npmjs.com/cli/v8/commands/npx), npx needs package name rather than the binary name. so executing `npx y-websocket-server` would not download and run the server binary in `y-websocket`, it would download from [y-websocket-server](https://npmjs.com/package/y-websocket-server) instead, which could lead to remote arbitrage code execution.
…for exponential backoff
correct npx directive
…e because 'process' listens to' exit 'events and uses anonymous functions to contain' this'
Improve the judgment condition of WS connection status in resync
Correct me if I'm wrong, but mutex/mux are no longer being used, right?
remove vestigial mutex code
Added a comment to clarify why reply messages are not sent when their length is 1. Alternatively we could also create a function with a descriptive name of the check being performed,
```js
function hasMessage(encoder) {
return encoding.length(encoder) > 1;
}
```
The `if` statement would then look something like,
```js
if (hasMessage(encoder)) {
send(...);
}
```
Thoughts?
fix: `server.listen` port
Export message type constants
Update utils.js
Add server side transaction origin
fix: WebSocket is already in CLOSING or CLOSED state.
feat: add worklows PR & master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the v2 branch up to date with the current changes to y-websocket on master.
I'd love to see this published as an official version, as I need a version that is pure esm.
Huly®: YJS-720