Update utils.js #114
Merged
Update utils.js #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment to clarify why reply messages are not sent when their length is 1. Alternatively we could also create a function with a descriptive name of the check being performed,
```js
function hasMessage(encoder) {
return encoding.length(encoder) > 1;
}
```
The `if` statement would then look something like,
```js
if (hasMessage(encoder)) {
send(...);
}
```
Thoughts?
|
That works, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a comment to clarify why reply messages are not sent when their length is 1. Alternatively we could also create a function with a descriptive name of the check being performed,
The
ifstatement would then look something like,Thoughts?
Huly®: YJS-751