CA-417951: Migration and detecting RPU checks #6698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielBuica
force-pushed
the
private/dbuica/rpu-version-control
branch
from
e390fea to
1859431
Compare
edwintorok
reviewed
Oct 8, 2025
|
The xapi-aux library has a version module to handle version strings; would this be useful? |
psafont
reviewed
Oct 8, 2025
robhoes
reviewed
Oct 8, 2025
GabrielBuica
force-pushed
the
private/dbuica/rpu-version-control
branch
from
1859431 to
9114ed1
Compare
robhoes
approved these changes
Oct 8, 2025
added 2 commits
October 8, 2025 14:37
Turns out that the previous fixes on these were too strict. As the checks for allowing migration and detecting RPU are a bit different now. For migration we want to make sure we are migrating on the same or higher versions for: platform, xapi, and xen versions. For detecting RPU we want the pool to have the same versions for platform and xapi build (only major and minor numbers). Signed-off-by: Gabriel Buica <[email protected]>
Currently, when a new host is created on the coordinator, it has only a minimal record added for it in the database. And this record only adds the platform version. While the rest is populated when `db_sync` is called. With the new checks for detecting RPU, this results in a 30s interval when the coordinator thinks an RPU is in progress when a new host is added to a pool. Because we already check for for xapi build version, major and minor numbers, in the pre-join checks, it is safe to add this in the minimal record created for a new host (before db_sync gets called). Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/rpu-version-control
branch
from
9114ed1 to
d08b39a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While attempting to improve these checks in #6655, this caused the system to detect false positives for detecting RPU.
This splits the logic between RPU and migration version checks.