XSI-1987 & CA-416462: Fix RPU host evacuation version check #6655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psafont
reviewed
Sep 9, 2025
robhoes
reviewed
Sep 9, 2025
Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/fix-rpm-build
branch
from
6f1b41d to
b05bb7c
Compare
psafont
reviewed
Sep 12, 2025
robhoes
approved these changes
Sep 15, 2025
psafont
approved these changes
Sep 15, 2025
|
@GabrielBuica You could squash the fix-ups to resolve the sign-off issues. |
Rolling pool upgrades should only allow VMs to be evacuated to hosts that have the same or higher versions of xapi build or xen. Previously, the check was done only for platform version. Signed-off-by: Gabriel Buica <[email protected]>
GabrielBuica
force-pushed
the
private/dbuica/fix-rpm-build
branch
from
2118d25 to
cb8fad4
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
xapi-project:master
with commit Sep 22, 2025
cad8578
15 of 16 checks passed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 13, 2025
While attempting to improve these checks in #6655, this caused the system to detect false positives for detecting RPU. This splits the logic between RPU and migration version checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling pool upgrades should only allow VMs to be evacuated to hosts that have the same or higher versions of xapi build or xen.
Previously, the check was done only for platform vision.
I will run a BST again after I squash the fixup to be sure. Otherwise, I think this is ready.