Avoid OCaml 5.3 compiler warnings #6691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OCaml 5 is particularly picky here and wants all those dependencies explicitly (and tediously) declared, otherwise it will print `ocaml_deprecated_auto_include` alerts. In the case of `unix`, it is used nearly everywhere. Signed-off-by: Rob Hoes <[email protected]>
andyhhp
reviewed
Sep 29, 2025
Comment on lines
147
to
152
| CAMLprim value stub_xenctrlext_get_boot_cpufeatures(value xch_val) | ||
| { | ||
| CAMLparam1(xch_val); | ||
| #if defined(XENCTRL_HAS_GET_CPUFEATURES) | ||
| CAMLparam1(xch_val); | ||
| CAMLlocal1(v); | ||
| uint32_t a, b, c, d, e, f, g, h; |
There was a problem hiding this comment.
It looks like XENCTRL_HAS_GET_CPUFEATURES and xc_get_boot_cpufeatures was always local to the XenServer patchqueue, and deleted by xenserver/xen.pg@b39aeba#diff-6c3fe5afba8527c7d13d37280dbc422a422f357c226fc8d1759031a10a32aa20L37 in 2015.
It's probably worth cleaning up the dead code here too
There was a problem hiding this comment.
Thanks, it indeed turns out that this whole function is unused in xenopsd. I'll zap it.
last-genius
approved these changes
Sep 30, 2025
The format of the error that this test checks for is printed a little differently by the OCaml 5 compiler (the name of the tag is now quoted). Adapt the test a little to make it work both for OCaml 4 and 5. Signed-off-by: Rob Hoes <[email protected]>
Signed-off-by: Rob Hoes <[email protected]>
robhoes
force-pushed
the
prepare-for-5
branch
from
27f5b38 to
1c36d6b
Compare
|
scheduler test is failing now, I'll rerun |
Merged
via the queue into
xapi-project:master
with commit Sep 30, 2025
0f0775b
16 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.