fix(astro): astro:config/server urls serialization #14460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7ea3d82 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #14460 will not alter performanceComparing Summary
|
ascorbic
reviewed
Sep 30, 2025
| <p id="out-dir">{outDir}</p> | ||
| <p id="src-dir">{srcDir}</p> | ||
| <p id="root">{root}</p> | ||
| <p id="root-type">{typeof root}</p> |
There was a problem hiding this comment.
How about testing instanceof URL?
There was a problem hiding this comment.
Yeah I don't know why I didn't do that, updated!
ascorbic
reviewed
Sep 30, 2025
Comment on lines
111
to
113
| if (Array.isArray(value)) { | ||
| return JSON.stringify(value); | ||
| } |
There was a problem hiding this comment.
Are arrays always of scalars?
There was a problem hiding this comment.
Updated to handle this case
delucis
reviewed
Sep 30, 2025
|
Yeah I thought about this and I think the types should be the source of truth here |
delucis
approved these changes
Sep 30, 2025
ascorbic
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
astro:config/serverURLS, which were emitted as strings instead of URLsTesting
Updated
Docs
Changeset