fix(astro): astro:config/server urls serialization (#14460)

Author: florian-lefebvre

.changeset/full-peas-do.md

@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Fixes a case where `astro:config/server` values typed as URLs would be serialized as strings

packages/astro/src/manifest/virtual-module.ts

@@ -68,7 +68,7 @@ function serializeClientConfig(manifest: SSRManifest): string {
 
 	const output = [];
 	for (const [key, value] of Object.entries(serClientConfig)) {
-		output.push(`export const ${key} = ${JSON.stringify(value)};`);
+		output.push(`export const ${key} = ${stringify(value)};`);
 	}
 	return output.join('\n') + '\n';
 }
@@ -102,7 +102,22 @@ function serializeServerConfig(manifest: SSRManifest): string {
 	};
 	const output = [];
 	for (const [key, value] of Object.entries(serverConfig)) {
-		output.push(`export const ${key} = ${JSON.stringify(value)};`);
+		output.push(`export const ${key} = ${stringify(value)};`);
 	}
 	return output.join('\n') + '\n';
 }
+
+function stringify(value: any): string {
+	if (Array.isArray(value)) {
+		return `[${value.map(e => stringify(e)).join(', ')}]`;
+	}
+	if (value instanceof URL) {
+		return `new URL(${JSON.stringify(value)})`;
+	}
+	if (typeof value === 'object') {
+		return `{\n${Object.entries(value)
+			.map(([k, v]) => `${JSON.stringify(k)}: ${stringify(v)}`)
+			.join(',\n')}\n}`;
+	}
+	return JSON.stringify(value);
+}

packages/astro/test/fixtures/astro-manifest/src/pages/server.astro

@@ -14,6 +14,7 @@ import { root, outDir, srcDir, build, cacheDir } from "astro:config/server";
 <p id="out-dir">{outDir}</p>
 <p id="src-dir">{srcDir}</p>
 <p id="root">{root}</p>
+<p id="root-url">{root instanceof URL}</p>
 <p id="cache-dir">{cacheDir}</p>
 <p id="build-client">{build.client}</p>
 <p id="build-server">{build.server}</p>

packages/astro/test/serializeManifest.test.js

@@ -132,6 +132,8 @@ describe('astro:config/server', () => {
 			assert.ok($('#root').text().endsWith('/'));
 			assert.ok($('#build-client').text().endsWith('/dist/client/'));
 			assert.ok($('#build-server').text().endsWith('/dist/server/'));
+			// URL
+			assert.equal($('#root-url').text(), 'true');
 		});
 	});
 
@@ -152,6 +154,8 @@ describe('astro:config/server', () => {
 			assert.ok($('#root').text().endsWith('/'));
 			assert.ok($('#build-client').text().endsWith('/dist/client/'));
 			assert.ok($('#build-server').text().endsWith('/dist/server/'));
+			// URL
+			assert.equal($('#root-url').text(), 'true');
 		});
 	});
 
@@ -179,6 +183,8 @@ describe('astro:config/server', () => {
 			assert.ok($('#root').text().endsWith('/'));
 			assert.ok($('#build-client').text().endsWith('/dist/client/'));
 			assert.ok($('#build-server').text().endsWith('/dist/server/'));
+			// URL
+			assert.equal($('#root-url').text(), 'true');
 		});
 	});
 });