Support vertex detection #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webdevred
force-pushed
the
support-vertex-detection
branch
7 times, most recently
from
2f8bb25 to
d5fcdd9
Compare
- Added special-case renaming logic for SupportTree in `renameVertexId` - Updated `buildTreeForType` to return support vertices separately - Introduced helpers: * addSupportVertex / addSupportVertices * sortSupportVertices - Modified `addVertexTreeToForest` to insert and sort support vertices - Simplified `moveVerticesInVertexForest` by removing SupportTree special casing - Unified tree ordering with SupportTree as first-class: [Left, Middle, Right, Support]
webdevred
force-pushed
the
support-vertex-detection
branch
2 times, most recently
from
3e68810 to
58b9ca2
Compare
webdevred
force-pushed
the
support-vertex-detection
branch
from
58b9ca2 to
dc25f99
Compare
webdevred
added a commit
that referenced
this pull request
Oct 5, 2025
Updated examle files to showcase how the recent changes to Transformation code affect jbeam. The major changes to transformation code are in #69 The changes to transformation which are related to this new example files are the following: - Transformation reimplemenation: before errors were handled less safely and meta groups interrupting vertex groups was not supported #2 - Transformation refactoring: split Transformation into different files and added improved how comments and metadata is handled when moving vertices #41 - Support vertex detection: implemented detection of support vertices and automatically moving them to their own tree #52 - Associate comments without newline before with prior node #56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.