Skip to content

Transformation.hs refactoring #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Sep 6, 2025
Merged

Transformation.hs refactoring #41

merged 16 commits into from
Sep 6, 2025

Conversation

@webdevred
Copy link
Owner

@webdevred webdevred commented Sep 2, 2025 •
edited
Loading

  • Updates sorting, renaming, and vertex forest construction to operate on directly CommentGroups.
  • Handles comments and global metas more consistently across vertex trees.
  • Reuses MetaMaps across CommentGroups to optimize memory usage.
  • Splits large module into VertexExtraction and Transformation for clearer structure.
  • Preserves existing vertex coordinates and behavior; no functional changes.
  • Add support for multiple groups of same types with different prefixes

Branch called new_transformation2 to celebrate the joy when new_transformation was merged into master after the summer.

@webdevred webdevred force-pushed the new_transformation2 branch 10 times, most recently from 7a8f709 to f6c32b9 Compare September 3, 2025 14:59
@webdevred
Refactored vertex extraction to separate module
65e2bf2
@webdevred
Replace T.dropWhileEnd isDigit with dropIndex
4e64ab3
@webdevred
Refactor VertexTree to remove VertexTreeEntry
90508c2 
- Removed the VertexTreeEntry type entirely.
- Updated VertexTree to store comments and comment groups directly (tComments, tCommentGroups).
- Refactored transformation functions to work with CommentGroup directly instead of VertexTreeEntry.
- Improved handling of comments and their association with vertices.
- Removed legacy tMetaNodes and simplified meta handling in VertexTree.
- Structural refactor that also improves comment processing.
@webdevred
Dont account for SupportTree when calculating globals and locals
dc56bdc
@webdevred
Properly add sideComment to groups if missing there are no tComments
cf7ba27
@webdevred
Refactor AnnotatedVertex field names from c* to a*
1274c20 
- Renamed fields in `AnnotatedVertex`:
  * cComments -> aComments
  * cVertex   -> aVertex
  * cMeta     -> aMeta
- Updated all references in:
  * `Transformation.hs`
  * `VertexExtraction.hs`
@webdevred
Migrate to reludes NonEmpty
7d21547
@webdevred
Removed redundant foldable1-classes-compat dependency
69c813c
@webdevred
Dont remove last character in short vertex prefixes
7c61144
@webdevred webdevred merged commit 6a87c93 into master Sep 6, 2025
13 checks passed
@webdevred webdevred deleted the new_transformation2 branch September 6, 2025 07:55
This was referenced Oct 2, 2025
Open
Merged
webdevred added a commit that referenced this pull request Oct 5, 2025
@webdevred
New example files (#74)
51b9684 
Updated examle files to showcase how the recent changes to Transformation code affect jbeam. The major changes to transformation code are in #69

The changes to transformation which are related to this new example files are the following:

- Transformation reimplemenation: before errors were handled less safely and meta groups interrupting vertex groups was not supported #2
- Transformation refactoring: split Transformation into different files and added improved how comments and metadata is handled when moving vertices #41
- Support vertex detection: implemented detection of support vertices and automatically moving them to their own tree  #52
- Associate comments without newline before with prior node #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@webdevred