-
-
Notifications
You must be signed in to change notification settings - Fork 11.2k
[Benchmark] Update bench doc with mtbench, blazedit, spec bench #24450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ywang96
merged 4 commits into
vllm-project:main
from
ekagra-ranjan:er-dataset-doc-update
Sep 9, 2025
Merged
[Benchmark] Update bench doc with mtbench, blazedit, spec bench #24450
ywang96
merged 4 commits into
vllm-project:main
from
ekagra-ranjan:er-dataset-doc-update
Sep 9, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ekagra Ranjan <[email protected]>
Signed-off-by: Ekagra Ranjan <[email protected]>
d3a7050 to
54eed19
Compare
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the benchmarking documentation to include instructions for mtbench, blazedit, and spec bench. The changes are mostly good, but I found a duplicated entry for HuggingFace-MTBench in the dataset overview table which should be removed.
Signed-off-by: Ekagra Ranjan <[email protected]>
ywang96
approved these changes
Sep 9, 2025
skyloevil
pushed a commit
to skyloevil/vllm
that referenced
this pull request
Sep 13, 2025
…-project#24450) Signed-off-by: Ekagra Ranjan <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…-project#24450) Signed-off-by: Ekagra Ranjan <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 10, 2025
…-project#24450) Signed-off-by: Ekagra Ranjan <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
xuebwang-amd
pushed a commit
to xuebwang-amd/vllm
that referenced
this pull request
Oct 24, 2025
…-project#24450) Signed-off-by: Ekagra Ranjan <[email protected]> Signed-off-by: xuebwang-amd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update bench doc with mtbench, blazedit, spec bench instructions. Merge after these
#23605
#23563