Skip to content

Conversation

@SzymonOzog
Copy link
Contributor

Now it should be correctly initialized although I'm seeing a bit of a performance degradation when using MLA (33 vs 37 tok/s)

Signed-off-by: SzymonOzog <[email protected]>
@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@cjackal
Copy link
Contributor

cjackal commented Mar 12, 2025

It seems do the same fix as #14555

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. QQ Is there a way you could refactor this to use the shared _process_weights_after_loading function in this file?

@mgoin
Copy link
Member

mgoin commented Mar 13, 2025

Closing in favor of #14555

@mgoin mgoin closed this Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants