-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[BugFix][TritonMLA] Process weights after model loading for GGUF #14555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: TianyuanWu <[email protected]>
0020fa5 to
fe94ef2
Compare
|
Don't know why but bot failed to ping vLLM maintainers; I guess @Isotr0py is the right person here. |
mgoin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…m-project#14555) Signed-off-by: TianyuanWu <[email protected]> Signed-off-by: Richard Liu <[email protected]>
…m-project#14555) Signed-off-by: TianyuanWu <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…m-project#14555) Signed-off-by: TianyuanWu <[email protected]>
…m-project#14555) Signed-off-by: TianyuanWu <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Issue Description
Observed the following error message when trying to deploy DeepSeek R1 Unsloth GGUF quantized model with MLA enabled on Triton MLA backend:
Fix
It turns out that
W_Q_UKnever got initialized. To fix it, call_process_weights_after_loading()right after model loading to properly process the weight attributes.Local Verification
With this PR, the mentioned error message cannot be reproduced anymore, and the DeepSeek GGUF model can be deployed successfully.