fix: tsconfig jsx overrides esbuild options, reverts #10374
#10714
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts #10374.
That PR caused many breakage than I expected.
When
tsconfig.json'sjsxfield has'preserve'andesbuild.jsx: 'transform'invite.config.js,'preserve'is applied. (Previously'transform'was applied.)So
tsconfig.jsonhas precedence overesbuildoptions. This is similar to #10296.I think we should revert this one and reintroduce this in Vite 4. (Maybe esbuild options should have precedence)
fixes #10670
fixes #10685
fixes #10702
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).