Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 7, 2022

Description

Use alwaysStrict, jsx, jsxImportSource fields when transpiling TS.
https://esbuild.github.io/content-types/#tsconfig-json

jsx, jsxImportSource is supported by evanw/esbuild#2349 that is supported from esbuild v0.14.51+.

I'm not sure if we should include alwaysStrict. Rollup will always output "use strict"; unless strict: false is set. (and ESM is always strict mode)

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 7, 2022
@bluwy
Copy link
Member

bluwy commented Oct 14, 2022

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 14, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ✅ success
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ❌ failure
vitest ✅ success
windicss ✅ success

@sapphi-red
Copy link
Member Author

I think vitepress will be fixed by #10375.
I've merged main branch to this PR to fix that.
ecosystem-ci should pass now.

@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 14, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ❌ failure
vite-plugin-ssr ❌ failure
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@sapphi-red
Copy link
Member Author

It seems svelte and vite-plugin-ssr are failing with v3.2.0-beta.2 too.

@patak-dev patak-dev merged commit f542727 into vitejs:main Oct 14, 2022
@sapphi-red sapphi-red deleted the feat/update-esbuild-compilation-fields branch October 15, 2022 02:55
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Oct 30, 2022
@bluwy bluwy mentioned this pull request Nov 23, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants