Skip to content

fixed issue with runtime-config returning undefined when building or in a development environment #15777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 4, 2020
Merged

fixed issue with runtime-config returning undefined when building or in a development environment #15777

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
acf5ae3
fix https://github.com/vercel/next.js/issues/7713#issuecomment-643632270
jtaox Aug 1, 2020
d2e6910
fixed prettier
jtaox Aug 1, 2020
91cfbaf
add test case for runtime-config in the development environment https…
jtaox Aug 4, 2020
af4f673
Merge remote-tracking branch 'upstream/canary' into fix-runtime-confi…
ijjk Aug 4, 2020
b6e3bd6
Update test a bit
ijjk Aug 4, 2020
5f9ebe6
Merge branch 'canary' into fix-runtime-config-undefined
kodiakhq[bot] Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/next/server/next-dev-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,10 +482,16 @@ export default class DevServer extends Server {
// from waiting on them for the page to load in dev mode

const __getStaticPaths = async () => {
const { publicRuntimeConfig, serverRuntimeConfig } = this.nextConfig

const paths = await this.staticPathsWorker.loadStaticPaths(
this.distDir,
pathname,
!this.renderOpts.dev && this._isLikeServerless
!this.renderOpts.dev && this._isLikeServerless,
{
publicRuntimeConfig,
serverRuntimeConfig,
}
)
return paths
}
Expand Down
8 changes: 7 additions & 1 deletion packages/next/server/static-paths-worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import { buildStaticPaths } from '../build/utils'
import { loadComponents } from '../next-server/server/load-components'
import '../next-server/server/node-polyfill-fetch'

type RuntimeConfig = any

let workerWasUsed = false

// we call getStaticPaths in a separate process to ensure
Expand All @@ -10,14 +12,18 @@ let workerWasUsed = false
export async function loadStaticPaths(
distDir: string,
pathname: string,
serverless: boolean
serverless: boolean,
config: RuntimeConfig
) {
// we only want to use each worker once to prevent any invalid
// caches
if (workerWasUsed) {
process.exit(1)
}

// update work memory runtime-config
require('./../next-server/lib/runtime-config').setConfig(config)

const components = await loadComponents(distDir, pathname, serverless)

if (!components.getStaticPaths) {
Expand Down