Skip to content

fixed issue with runtime-config returning undefined when building or in a development environment #15777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 4, 2020
Merged

fixed issue with runtime-config returning undefined when building or in a development environment #15777

merged 6 commits into from
Aug 4, 2020

Conversation

jtaox
Copy link
Contributor

@jtaox jtaox commented Aug 1, 2020

@ijjk ijjk added the type: next label Aug 1, 2020
@jtaox
Copy link
Contributor Author

jtaox commented Aug 1, 2020

reproduction repo

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 13.2s 12s -1.2s
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +848 B
Page Load Tests Overall increase ✓
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.52 2.211 -0.31
/ avg req/sec 992.04 1130.58 +138.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.511 1.338 -0.17
/error-in-render avg req/sec 1654.9 1869.13 +214.23
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
index.html gzip 948 B 948 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 12.7s 12.9s ⚠️ +177ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +848 B
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: acf5ae3

@ijjk
Copy link
Member

ijjk commented Aug 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 12.9s 12.7s -133ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Page Load Tests Overall increase ✓
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.27 2.267 0
/ avg req/sec 1101.28 1102.82 +1.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.302 1.216 -0.09
/error-in-render avg req/sec 1919.58 2055.37 +135.79
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Rendered Page Sizes
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
index.html gzip 948 B 948 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 14.4s 14.6s ⚠️ +105ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..70d8.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-06588f2..f65e.js gzip 6.73 kB 6.73 kB ✓
webpack-488d..c0e7.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-62e1f09..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-4f62..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-05..1236.js gzip 30.8 kB 30.8 kB ✓
Overall change 30.8 kB 30.8 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-8f5f611..1f7b.js gzip 1.28 kB 1.28 kB ✓
_error-a98d9..5cb7.js gzip 3.45 kB 3.45 kB ✓
hooks-f7f3d0..7465.js gzip 887 B 887 B ✓
index-08fb3f..c0e9.js gzip 227 B 227 B ✓
link-6f8445b..99e1.js gzip 1.3 kB 1.3 kB ✓
routerDirect..8aa1.js gzip 284 B 284 B ✓
withRouter-f..e777.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-669dbe5..dule.js gzip 626 B 626 B ✓
_error-d5979..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-805c40..dule.js gzip 387 B 387 B ✓
index-6ba5a4..dule.js gzip 226 B 226 B ✓
link-91516ae..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-d..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 274 B 274 B ✓
_buildManife..dule.js gzip 282 B 282 B ✓
Overall change 556 B 556 B ✓
Serverless bundles
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: d2e6910

@jtaox jtaox mentioned this pull request Aug 1, 2020
Closed
ijjk
ijjk requested changes Aug 3, 2020
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR, can you add tests for this that fail without this change and are working with it? See details for running the tests in our contributing doc

@ijjk
Copy link
Member

ijjk commented Aug 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 12.9s 12.7s -187ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Page Load Tests Overall increase ✓
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.359 2.362 0
/ avg req/sec 1059.86 1058.36 ⚠️ -1.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.493 1.399 -0.09
/error-in-render avg req/sec 1674.38 1786.86 +112.48
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
index.html gzip 944 B 944 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 14.3s 14.3s ⚠️ +19ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 91cfbaf

@jtaox jtaox requested a review from ijjk August 4, 2020 15:02
@ijjk
Copy link
Member

ijjk commented Aug 4, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 12.8s 12.9s ⚠️ +182ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.367 2.415 ⚠️ +0.05
/ avg req/sec 1055.99 1035.34 ⚠️ -20.65
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.413 1.437 ⚠️ +0.02
/error-in-render avg req/sec 1768.82 1739.29 ⚠️ -29.53
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
index.html gzip 944 B 944 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 14.9s 14.3s -640ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: b6e3bd6

@ijjk
Copy link
Member

ijjk commented Aug 4, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 10.8s 11s ⚠️ +190ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.922 2.055 ⚠️ +0.13
/ avg req/sec 1300.93 1216.26 ⚠️ -84.67
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.134 1.096 -0.04
/error-in-render avg req/sec 2204.37 2281.17 +76.8
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
index.html gzip 944 B 944 B ✓
link.html gzip 953 B 953 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
buildDuration 12.4s 12.3s -115ms
nodeModulesSize 65.5 MB 65.5 MB ⚠️ +847 B
Client Bundles (main, webpack, commons)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..afbf.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-2ecb3b8..bd63.js gzip 6.73 kB 6.73 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.8 kB 56.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-dbff266..dule.js gzip 5.81 kB 5.81 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-e97733c..af21.js gzip 1.3 kB 1.3 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-fbb1d2e..dule.js gzip 1.25 kB 1.25 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_buildManifest.js gzip 272 B 272 B ✓
_buildManife..dule.js gzip 280 B 280 B ✓
Overall change 552 B 552 B ✓
Serverless bundles
vercel/next.js canary jtaox/next.js fix-runtime-config-undefined Change
_error.js 1.02 MB 1.02 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.02 MB 1.02 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.2 MB 5.2 MB ✓
Commit: 5f9ebe6

@kodiakhq kodiakhq bot merged commit 35e4a37 into vercel:canary Aug 4, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

publicRuntimeConfig shouldn’t be undefined on build

2 participants

@jtaox @ijjk