Skip to content

fix: return empty Text component if renderer is updated with null (#8168) (CP: 24.8) #8173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2025
Merged

fix: return empty Text component if renderer is updated with null (#8168) (CP: 24.8) #8173

merged 1 commit into from
Oct 20, 2025

Conversation

@vaadin-bot
Copy link
Collaborator

@vaadin-bot vaadin-bot commented Oct 20, 2025

No description provided.

@DiegoCardoso @vaadin-bot
fix: return empty Text component if renderer is updated with null (…
5b14d80 
…#8168)

Add the same behavior as when `createComponenet` is called and the
component renderer returns `null` to the `updateComponent` method. That
prevents a NPE in the `AbstractComponentDataGenerator#refreshData`
method when it tries to call `getElement` in the updated component.

Fixes #6825
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DiegoCardoso DiegoCardoso merged commit 65db975 into 24.8 Oct 20, 2025
5 checks passed
@DiegoCardoso DiegoCardoso deleted the cherry-pick-8168-to-24.8-1760965274818 branch October 20, 2025 13:29
@vaadin-bot
Copy link
Collaborator Author

vaadin-bot commented Oct 29, 2025

This ticket/PR has been released with Vaadin 24.8.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees

No one assigned

Labels

Released with Vaadin 24.8.12

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaadin-bot @DiegoCardoso