fix: return empty Text component if renderer is updated with null
#8168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the same behavior as when `createComponenet` is called and the component renderer returns `null` to the `updateComponent` method. That prevents a NPE in the `AbstractComponentDataGenerator#refreshData` method when it tries to call `getElement` in the updated component. Fixes #6825
DiegoCardoso
force-pushed
the
fix/renderer/update-null-check
branch
from
4b928dd to
82839d4
Compare
|
tomivirkki
approved these changes
Oct 20, 2025
DiegoCardoso
added a commit
that referenced
this pull request
Oct 20, 2025
…#8168) (#8173) Add the same behavior as when `createComponenet` is called and the component renderer returns `null` to the `updateComponent` method. That prevents a NPE in the `AbstractComponentDataGenerator#refreshData` method when it tries to call `getElement` in the updated component. Fixes #6825 Co-authored-by: Diego Cardoso <[email protected]>
DiegoCardoso
added a commit
that referenced
this pull request
Oct 20, 2025
…#8168) (#8172) Add the same behavior as when `createComponenet` is called and the component renderer returns `null` to the `updateComponent` method. That prevents a NPE in the `AbstractComponentDataGenerator#refreshData` method when it tries to call `getElement` in the updated component. Fixes #6825 Co-authored-by: Diego Cardoso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the same behavior as when
createComponenetis called and the component renderer returnsnullto theupdateComponentmethod. That prevents a NPE in theAbstractComponentDataGenerator#refreshDatamethod when it tries to callgetElementin the updated component.Fixes #6825