Store only symbols on DateTimeFormat #518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon #517 by switching our struct to store only symbols.
I'm not super attached to it, and I believe we'll want to store more than symbols, which I think should end up being a custom struct like:
but for now I think it should do and fortunately refactoring this is trivial.
The main value of this is that we're avoiding storing all patterns we don't need but also, it allows us to just parse the pattern if needed and store just the parsed pattern.
This, on the other hands opens up possibility of storing borrowed strings in pattern, and zero-alloc parsing of patterns.