Skip to content

Conversation

@zbraniecki
Copy link
Member

In my journey through a good generic SimpleFormatter, I started looking at the DateTimeFormat and how it handles data.

This is the first step of the clean up, it just separates the trait methods between Symbols and Patterns.

@zbraniecki zbraniecki requested a review from sffc March 3, 2021 03:17
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please make the CI pass.

@zbraniecki
Copy link
Member Author

I can't. It's bheisler/TinyTemplate#16 so we gotta wait for a new release.

@sffc
Copy link
Member

sffc commented Mar 3, 2021

I thought we had a Cargo.lock file so our CI would be more resilient. (You know how I feel about CI breaking because of an external change)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3760a101f41ef0e5f66c546f3b6f0ac04b91dc40-PR-517

  • 6 of 12 (50.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 72.696%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/datetime/src/format.rs 1 4 25.0%
components/datetime/src/provider/helpers.rs 5 8 62.5%
Files with Coverage Reduction New Missed Lines %
components/datetime/src/provider/helpers.rs 1 58.95%
Totals Coverage Status
Change from base Build b15c0b36901095406a67e3620a3d1d0e294b7692: -0.01%
Covered Lines: 4851
Relevant Lines: 6673

💛 - Coveralls

@zbraniecki zbraniecki merged commit 68d6b2b into unicode-org:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants