Skip to content

Update go version for twirp compat tests #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2024
Merged

Update go version for twirp compat tests #636

merged 2 commits into from
Mar 13, 2024

Conversation

@timostamm
Copy link
Owner

@timostamm timostamm commented Mar 13, 2024 •
edited
Loading

CI started failing with:

@protobuf-ts/twirp-transport: go: downloading google.golang.org/protobuf v1.33.0
Error: @protobuf-ts/twirp-transport: /home/runner/go/pkg/mod/github.com/golang/[email protected]/jsonpb/decode.go:19:2: //go:build comment without // +build comment

This updates to 1.17 to support the new build constraints.

@timostamm timostamm merged commit 14e1dfd into main Mar 13, 2024
@timostamm timostamm mentioned this pull request Mar 13, 2024
Merged
This was referenced May 24, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request May 24, 2024
Open
This was referenced Aug 10, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 10, 2024
Open
Open
@X-oss-byte X-oss-byte mentioned this pull request Sep 22, 2024
Open
@timostamm timostamm deleted the update-go branch March 9, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timostamm