Extend Object prototype for message instances #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcready
reviewed
Mar 8, 2024
Owner
|
@erichiggins0, CI was failing because of an issue with go. Pushed up #636 to your fork. |
timostamm
approved these changes
Mar 13, 2024
Owner
timostamm
left a comment
timostamm
left a comment
There was a problem hiding this comment.
Following the discussion in #582 (comment), LGTM.
Owner
|
Released in v2.9.4 |
This was referenced May 24, 2024
This was referenced Aug 10, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #582, message instances don't behave exactly like simple objects, as their prototype only includes a
Symbol("protobuf-ts/message-type")field and is missing fields normally present in a simple object (e.g.constructor). For us, this specifically causes an issue when using mobx to observe changes to message instances - it only allows observing objects that have aconstructormethod in their prototype that matches the method for simple objects.This fixes the problem by copying the default object prototype and adding a
Symbol("protobuf-ts/message-type")field, rather than starting from an empty prototype.