Skip to content

Extend Object prototype for message instances #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Extend Object prototype for message instances #618

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e90694
Extend Object prototype for message instances
eric-higgins-ai Dec 21, 2023
0c012ba
address comment
eric-higgins-ai Mar 8, 2024
a9ac176
remove double semicolon
eric-higgins-ai Mar 8, 2024
56606a9
Merge remote-tracking branch 'upstream/main' into copy-object-prototype
timostamm Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/runtime/src/message-type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,14 @@ export class MessageType<T extends object> implements IMessageType<T> {
this.typeName = name;
this.fields = fields.map(normalizeFieldInfo);
this.options = options ?? {};
this.messagePrototype = Object.defineProperty({}, MESSAGE_TYPE, { value: this });
this.messagePrototype = this.messagePrototype = Object.defineProperty(
Object.create(
null,
Object.getOwnPropertyDescriptors(Object.getPrototypeOf({}))
),
MESSAGE_TYPE,
{ value: this },
);
this.refTypeCheck = new ReflectionTypeCheck(this);
this.refJsonReader = new ReflectionJsonReader(this);
this.refJsonWriter = new ReflectionJsonWriter(this);
Expand Down