Skip to content

Fix saving plots with no background #4244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Fix saving plots with no background #4244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a171813
If plot theme background is null, set to transparent when saving
karawoo Oct 7, 2020
dbcf3f1
Add test for svg with no background
karawoo Oct 20, 2020
0f3cd8a
Make checking for NULL background more concise with %||%
karawoo Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/save.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ ggsave <- function(filename, plot = last_plot(),
filename <- file.path(path, filename)
}
if (is_null(bg)) {
bg <- calc_element("plot.background", plot_theme(plot))$fill
bg <- calc_element("plot.background", plot_theme(plot))$fill %||% "transparent"
}
old_dev <- grDevices::dev.cur()
dev(filename = filename, width = dim[1], height = dim[2], bg = bg, ...)
Expand Down
15 changes: 15 additions & 0 deletions tests/testthat/test-ggsave.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,21 @@ test_that("ggsave uses theme background as image background", {
expect_true(grepl("fill: #00CCCC", bg))
})

test_that("ggsave can handle blank background", {
skip_if_not_installed("xml2")

path <- tempfile()
on.exit(unlink(path))
p <- ggplot(mtcars, aes(disp, mpg)) +
geom_point() +
theme(plot.background = element_blank())
ggsave(path, p, device = "svg", width = 5, height = 5)
img <- xml2::read_xml(path)
bg <- as.character(xml2::xml_find_first(img, xpath = "d1:rect/@style"))
expect_true(grepl("fill: none", bg))
})


# plot_dim ---------------------------------------------------------------

test_that("guesses and informs if dim not specified", {
Expand Down