Fix saving plots with no background #4244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
reviewed
Oct 20, 2020
R/save.r
Outdated
| @@ -88,6 +88,9 @@ ggsave <- function(filename, plot = last_plot(), | |||
| } | |||
| if (is_null(bg)) { | |||
| bg <- calc_element("plot.background", plot_theme(plot))$fill | |||
| if (is_null(bg)) { | |||
There was a problem hiding this comment.
Maybe just write:
bg <- calc_element("plot.background", plot_theme(plot))$fill %||% "transparent"There was a problem hiding this comment.
Oh of course, thanks, will update
clauswilke
approved these changes
Oct 22, 2020
sthagen
added a commit
to sthagen/tidyverse-ggplot2
that referenced
this pull request
Nov 7, 2020
Fix saving plots with no background (tidyverse#4244)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4212. When the
plot.backgrounditself is NULL,ggsave()will set the device bg to"transparent". This seems to work for devices that support transparent backgrounds. JPEGs and PDFs will have a white background, which seems ok.