Skip to content

test fix #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test fix #306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/embed/ts-embed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ export class TsEmbed {
const isDisabled = (
this.viewConfig.overrideOrgId !== undefined
|| this.embedConfig.disablePreauthCache === true
|| this.isFullAppEmbedWithVisiblePrimaryNavbar()
// || this.isFullAppEmbedWithVisiblePrimaryNavbar()
Copy link

@gemini-code-assist gemini-code-assist bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Commenting out code is generally discouraged as it can lead to confusion and code rot. If this condition is no longer necessary, it should be removed completely rather than commented out. Also, please consider removing the related comment block on lines 267-269 which now becomes stale. This change also seems to break existing unit tests.

);
return !isDisabled;
}
Expand Down
Loading