Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025

Please check the following before creating a Pull Request

  • If this is a new feature or piece of functionality, have you started a discussion and gotten agreement on it?
  • If it fixes a bug or problem, is there an issue to track it? If not, create one first and link it please so there's clear visibility.
  • Did you write tests to ensure you code works properly?

Description

Note: This PR has been rebased onto main. The benchmark calculator removal work was completed and merged in PR #3742. This PR is now redundant and can be closed.

Removes all references to a benchmark calculator feature that was documented but never implemented. The calculator component files never existed—only documentation and UI references remained, creating broken links.

Changes

Documentation cleanup:

  • docs/BENCHMARKS_IMPLEMENTATION.md - Removed BenchmarkCalculator component specification, usage examples, and file structure references (35 lines)
  • docs/docs/benchmarks/index.md - Removed broken calculator link from Interactive Comparison section
  • .github/scripts/process-benchmarks.js - Updated documentation generation template to exclude calculator references

UI component:

  • docs/src/components/BenchmarkHighlight/index.tsx - Removed "Calculate Your Savings" button linking to non-existent page

Rebase:

Verification

Repository-wide search confirms no active calculator references remain. Only unrelated example code (e.g., Calculator.Add() in test tutorials) uses the term "calculator". Documentation builds successfully.

This pull request was created as a result of the following prompt from Copilot chat.

Search the entire repository for any references to the benchmark calculator and remove or neutralize them. Specifically:

  • Find occurrences of the strings: "benchmark calculator", "benchmark-calculator", "BenchmarkCalculator", "benchmark_calculator" and similar variants (case-insensitive) across the repo (docs, README.md, .md files, .yml workflows, scripts, project files, and source files).
  • In documentation (README.md, docs/**, CONTRIBUTING.md, CHANGES.md, and any other markdown files): remove badges, links, sections, or paragraphs that mention the benchmark calculator. If the content is part of a larger section, remove only the sentences referencing the calculator and adjust surrounding text for grammatical correctness; if it's a standalone section, remove the section entirely. Where appropriate, replace the removed text with a short note such as "Benchmark calculator removed."
  • In .github/workflows/*.yml and any other CI or workflow files: remove jobs, steps, or uses that build, run, or publish the benchmark calculator. If a workflow would become empty as a result, remove the workflow file entirely. If only a step needs removal, keep the rest of the workflow intact.
  • In scripts (scripts/, tools/, or other shell/PowerShell/PS1/psm1 files): remove steps or script files that specifically build/run the benchmark calculator. If a script is shared, remove only the calculator-specific commands and leave the script functional.
  • In project/solution files (.csproj, .sln, paket files, build scripts): remove references to any project, target, or NuGet package that is only used for the benchmark calculator (do not remove dependencies used elsewhere). If removing a project causes a solution change, update the .sln accordingly.
  • Remove any CI badges or README badges that point to the benchmark calculator (images/links) and update the README if necessary to preserve layout.
  • Run a build (dotnet build -c Release) to ensure no compile errors are introduced by removing files/references. If build fails due to missing types/classes that were only used by the removed calculator, delete those files or guard them behind #if directives if they are not used.
  • Run repository-wide text search for leftover references and ensure none remain.

Make the changes on a new branch named remove-benchmark-calculator, commit with descriptive messages, and open a pull request titled "Remove benchmark calculator references and workflow steps" against the main branch of thomhurst/TUnit. In the PR description, list the files changed and explain why each change was needed, including any notable compile or test fixes applied.

Ensure the change follows the repository rules: do not modify TUnit.TestProject tests in a way that runs them differently; do not change source-generator behavior except where strictly needed to remove the calculator references; and do not introduce VSTest APIs.

After the PR is created, provide a summary of what you changed, link to the created PR, and list any remaining manual follow-ups (e.g., Update external docs or package indexes).

Original prompt

Search the entire repository for any references to the benchmark calculator and remove or neutralize them. Specifically:

  • Find occurrences of the strings: "benchmark calculator", "benchmark-calculator", "BenchmarkCalculator", "benchmark_calculator" and similar variants (case-insensitive) across the repo (docs, README.md, .md files, .yml workflows, scripts, project files, and source files).
  • In documentation (README.md, docs/**, CONTRIBUTING.md, CHANGES.md, and any other markdown files): remove badges, links, sections, or paragraphs that mention the benchmark calculator. If the content is part of a larger section, remove only the sentences referencing the calculator and adjust surrounding text for grammatical correctness; if it's a standalone section, remove the section entirely. Where appropriate, replace the removed text with a short note such as "Benchmark calculator removed."
  • In .github/workflows/*.yml and any other CI or workflow files: remove jobs, steps, or uses that build, run, or publish the benchmark calculator. If a workflow would become empty as a result, remove the workflow file entirely. If only a step needs removal, keep the rest of the workflow intact.
  • In scripts (scripts/, tools/, or other shell/PowerShell/PS1/psm1 files): remove steps or script files that specifically build/run the benchmark calculator. If a script is shared, remove only the calculator-specific commands and leave the script functional.
  • In project/solution files (.csproj, .sln, paket files, build scripts): remove references to any project, target, or NuGet package that is only used for the benchmark calculator (do not remove dependencies used elsewhere). If removing a project causes a solution change, update the .sln accordingly.
  • Remove any CI badges or README badges that point to the benchmark calculator (images/links) and update the README if necessary to preserve layout.
  • Run a build (dotnet build -c Release) to ensure no compile errors are introduced by removing files/references. If build fails due to missing types/classes that were only used by the removed calculator, delete those files or guard them behind #if directives if they are not used.
  • Run repository-wide text search for leftover references and ensure none remain.

Make the changes on a new branch named remove-benchmark-calculator, commit with descriptive messages, and open a pull request titled "Remove benchmark calculator references and workflow steps" against the main branch of thomhurst/TUnit. In the PR description, list the files changed and explain why each change was needed, including any notable compile or test fixes applied.

Ensure the change follows the repository rules: do not modify TUnit.TestProject tests in a way that runs them differently; do not change source-generator behavior except where strictly needed to remove the calculator references; and do not introduce VSTest APIs.

After the PR is created, provide a summary of what you changed, link to the created PR, and list any remaining manual follow-ups (e.g., Update external docs or package indexes).

This pull request was created as a result of the following prompt from Copilot chat.

Search the entire repository for any references to the benchmark calculator and remove or neutralize them. Specifically:

  • Find occurrences of the strings: "benchmark calculator", "benchmark-calculator", "BenchmarkCalculator", "benchmark_calculator" and similar variants (case-insensitive) across the repo (docs, README.md, .md files, .yml workflows, scripts, project files, and source files).
  • In documentation (README.md, docs/**, CONTRIBUTING.md, CHANGES.md, and any other markdown files): remove badges, links, sections, or paragraphs that mention the benchmark calculator. If the content is part of a larger section, remove only the sentences referencing the calculator and adjust surrounding text for grammatical correctness; if it's a standalone section, remove the section entirely. Where appropriate, replace the removed text with a short note such as "Benchmark calculator removed."
  • In .github/workflows/*.yml and any other CI or workflow files: remove jobs, steps, or uses that build, run, or publish the benchmark calculator. If a workflow would become empty as a result, remove the workflow file entirely. If only a step needs removal, keep the rest of the workflow intact.
  • In scripts (scripts/, tools/, or other shell/PowerShell/PS1/psm1 files): remove steps or script files that specifically build/run the benchmark calculator. If a script is shared, remove only the calculator-specific commands and leave the script functional.
  • In project/solution files (.csproj, .sln, paket files, build scripts): remove references to any project, target, or NuGet package that is only used for the benchmark calculator (do not remove dependencies used elsewhere). If removing a project causes a solution change, update the .sln accordingly.
  • Remove any CI badges or README badges that point to the benchmark calculator (images/links) and update the README if necessary to preserve layout.
  • Run a build (dotnet build -c Release) to ensure no compile errors are introduced by removing files/references. If build fails due to missing types/classes that were only used by the removed calculator, delete those files or guard them behind #if directives if they are not used.
  • Run repository-wide text search for leftover references and ensure none remain.

Make the changes on a new branch named remove-benchmark-calculator, commit with descriptive messages, and open a pull request titled "Remove benchmark calculator references and workflow steps" against the main branch of thomhurst/TUnit. In the PR description, list the files changed and explain why each change was needed, including any notable compile or test fixes applied.

Ensure the change follows the repository rules: do not modify TUnit.TestProject tests in a way that runs them differently; do not change source-generator behavior except where strictly needed to remove the calculator references; and do not introduce VSTest APIs.

After the PR is created, provide a summary of what you changed, link to the created PR, and list any remaining manual follow-ups (e.g., Update external docs or package indexes).


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove references to benchmark calculator across the repository Remove benchmark calculator references from documentation Nov 10, 2025
Copilot AI requested a review from thomhurst November 10, 2025 00:48
Copilot finished work on behalf of thomhurst November 10, 2025 00:48
@thomhurst
Copy link
Owner

@copilot rebase

Copy link
Contributor Author

Copilot AI commented Nov 10, 2025

@copilot rebase

Rebase completed. This PR is now redundant as the benchmark calculator removal work was already merged in PR #3742 (commit b2c33f5). The branch has been rebased onto main and can be closed.

Copilot finished work on behalf of thomhurst November 10, 2025 00:58
@thomhurst thomhurst closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants