Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025

Please check the following before creating a Pull Request

  • If this is a new feature or piece of functionality, have you started a discussion and gotten agreement on it?
  • If it fixes a bug or problem, is there an issue to track it? If not, create one first and link it please so there's clear visibility.
  • Did you write tests to ensure you code works properly?

Description

Removes all references to the benchmark calculator feature that was documented but never implemented.

Changes

Documentation:

  • docs/BENCHMARKS_IMPLEMENTATION.md: Removed calculator page section, BenchmarkCalculator component documentation, and file structure references
  • docs/docs/benchmarks/index.md: Removed "Interactive Comparison" section with calculator link

Scripts:

  • .github/scripts/process-benchmarks.js: Removed calculator section from generated benchmark documentation template

Components:

  • docs/src/components/BenchmarkHighlight/index.tsx: Removed "Calculate Your Savings" link to non-existent calculator page

Verification

Comprehensive search confirms zero references to "benchmark calculator" or "BenchmarkCalculator" remain. All remaining "calculator" references are legitimate test examples (e.g., Calculator.Add() in test documentation).

No actual calculator page, component directory, workflow steps, or implementation existed—only documentation referencing a planned feature.

Original prompt

Search the entire repository for references to the benchmark calculator and remove them. Actions to perform:

  1. Search (case-insensitive) for these and similar variants across the repo: "benchmark calculator", "benchmark-calculator", "BenchmarkCalculator", "benchmark_calculator", "benchmarkcalc".

  2. Documentation (.md, README.md, docs/**, CONTRIBUTING.md, CHANGES.md, .github/*.md):

    • Remove badges, links, paragraphs, or standalone sections that mention the benchmark calculator.
    • If a calculator reference appears inside a larger paragraph, remove the sentence and adjust surrounding text for grammar. If it is a standalone section, remove it and replace with a short note: "Benchmark calculator removed." where appropriate.
  3. Workflows (.github/workflows/*.yml):

    • Remove jobs, steps, or uses that build, run, publish, or reference the benchmark calculator. If a workflow is left empty by removals, delete the workflow file.
  4. Scripts (scripts/, tools/, *.sh, *.ps1, *.psm1):

    • Remove script files or script sections that are specific to building/running the benchmark calculator. Keep shared logic intact.
  5. Project/solution files (.csproj, .sln, paket, build scripts):

    • Remove project references, ProjectReference entries, or NuGet package references that are only used by the benchmark calculator. Update .sln to remove the project if necessary.
  6. Source code:

    • If the benchmark calculator project contains types/classes used nowhere else, remove those files. If removal causes compile errors because some types are referenced elsewhere, either remove those references or wrap calculator-only code behind #if directives so the build remains successful.
  7. Badges/images:

    • Remove CI badges or README badges that point to benchmark calculator results and update the README layout to preserve readability.
  8. Validation:

    • Run dotnet build -c Release to ensure the repository builds after changes. Make minimal fixes required to keep the build green (delete unused types, fix usings, etc.).
    • Run a repository-wide text search to ensure no leftover references remain.
  9. Branching and PR:

    • Create branch remove-benchmark-calculator from main.
    • Commit with clear messages for each logical change.
    • Open a pull request titled: "Remove benchmark calculator references and workflow steps" targeting main.
    • In the PR description, list files changed and explain why each change was made, plus any build/test fixes applied and any manual follow-ups required.

Constraints and repository rules to follow:

  • Do not modify TUnit.TestProject tests in a way that changes their behavior or how they run.
  • Do not change source-generator behavior except where strictly necessary to remove calculator references.
  • Do not introduce VSTest APIs.

Please proceed to create the branch, apply edits, run the build, and open the PR. After creating the PR, return the PR link and a summary of the files changed, reasoning for each change, and any remaining manual follow-ups.

This pull request was created as a result of the following prompt from Copilot chat.

Search the entire repository for references to the benchmark calculator and remove them. Actions to perform:

  1. Search (case-insensitive) for these and similar variants across the repo: "benchmark calculator", "benchmark-calculator", "BenchmarkCalculator", "benchmark_calculator", "benchmarkcalc".

  2. Documentation (.md, README.md, docs/**, CONTRIBUTING.md, CHANGES.md, .github/*.md):

    • Remove badges, links, paragraphs, or standalone sections that mention the benchmark calculator.
    • If a calculator reference appears inside a larger paragraph, remove the sentence and adjust surrounding text for grammar. If it is a standalone section, remove it and replace with a short note: "Benchmark calculator removed." where appropriate.
  3. Workflows (.github/workflows/*.yml):

    • Remove jobs, steps, or uses that build, run, publish, or reference the benchmark calculator. If a workflow is left empty by removals, delete the workflow file.
  4. Scripts (scripts/, tools/, *.sh, *.ps1, *.psm1):

    • Remove script files or script sections that are specific to building/running the benchmark calculator. Keep shared logic intact.
  5. Project/solution files (.csproj, .sln, paket, build scripts):

    • Remove project references, ProjectReference entries, or NuGet package references that are only used by the benchmark calculator. Update .sln to remove the project if necessary.
  6. Source code:

    • If the benchmark calculator project contains types/classes used nowhere else, remove those files. If removal causes compile errors because some types are referenced elsewhere, either remove those references or wrap calculator-only code behind #if directives so the build remains successful.
  7. Badges/images:

    • Remove CI badges or README badges that point to benchmark calculator results and update the README layout to preserve readability.
  8. Validation:

    • Run dotnet build -c Release to ensure the repository builds after changes. Make minimal fixes required to keep the build green (delete unused types, fix usings, etc.).
    • Run a repository-wide text search to ensure no leftover references remain.
  9. Branching and PR:

    • Create branch remove-benchmark-calculator from main.
    • Commit with clear messages for each logical change.
    • Open a pull request titled: "Remove benchmark calculator references and workflow steps" targeting main.
    • In the PR description, list files changed and explain why each change was made, plus any build/test fixes applied and any manual follow-ups required.

Constraints and repository rules to follow:

  • Do not modify TUnit.TestProject tests in a way that changes their behavior or how they run.
  • Do not change source-generator behavior except where strictly necessary to remove calculator references.
  • Do not introduce VSTest APIs.

Please proceed to create the branch, apply edits, run the build, and open the PR. After creating the PR, return the PR link and a summary of the files changed, reasoning for each change, and any remaining manual follow-ups.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove references to benchmark calculator from repository Remove benchmark calculator references Nov 10, 2025
Copilot AI requested a review from thomhurst November 10, 2025 00:44
Copilot finished work on behalf of thomhurst November 10, 2025 00:44
@thomhurst thomhurst marked this pull request as ready for review November 10, 2025 00:48
@thomhurst thomhurst merged commit b2c33f5 into main Nov 10, 2025
7 checks passed
@thomhurst thomhurst deleted the copilot/remove-benchmark-calculator-references-again branch November 10, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants